diff --git a/.changeset/brown-falcons-battle.md b/.changeset/brown-falcons-battle.md new file mode 100644 index 000000000..33752bf56 --- /dev/null +++ b/.changeset/brown-falcons-battle.md @@ -0,0 +1,9 @@ +--- +'@radix-ui/react-navigation-menu': patch +'@radix-ui/react-popover': patch +'@radix-ui/react-dialog': patch +'@radix-ui/react-select': patch +'@radix-ui/react-menu': patch +--- + +adjust aria-controls to triggers according to conditions. diff --git a/packages/react/dialog/src/dialog.tsx b/packages/react/dialog/src/dialog.tsx index 7bf964798..2a8ad2c1d 100644 --- a/packages/react/dialog/src/dialog.tsx +++ b/packages/react/dialog/src/dialog.tsx @@ -105,7 +105,7 @@ const DialogTrigger = React.forwardRef type="button" aria-haspopup="dialog" aria-expanded={context.open} - aria-controls={context.contentId} + aria-controls={context.open ? context.contentId : undefined} data-state={getState(context.open)} {...triggerProps} ref={composedTriggerRef} diff --git a/packages/react/menu/src/menu.tsx b/packages/react/menu/src/menu.tsx index bbc040aa7..43d5a5286 100644 --- a/packages/react/menu/src/menu.tsx +++ b/packages/react/menu/src/menu.tsx @@ -1049,7 +1049,7 @@ const MenuSubTrigger = React.forwardRef { diff --git a/packages/react/popover/src/popover.tsx b/packages/react/popover/src/popover.tsx index e9410e970..878fb8553 100644 --- a/packages/react/popover/src/popover.tsx +++ b/packages/react/popover/src/popover.tsx @@ -144,7 +144,7 @@ const PopoverTrigger = React.forwardRef