Skip to content

Commit 55b83ce

Browse files
committed
Addressed feedback
1 parent 33e7070 commit 55b83ce

File tree

1 file changed

+9
-18
lines changed
  • instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware

1 file changed

+9
-18
lines changed

instrumentation/opentelemetry-instrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -177,24 +177,15 @@ class _DjangoMiddleware(MiddlewareMixin):
177177

178178
@staticmethod
179179
def format_request_objects_in_headers(attributes):
180-
for key, value_list in list(attributes.items()):
181-
new_values = []
182-
for value in value_list:
183-
if hasattr(value, "__class__"):
184-
if isinstance(value, HttpRequest):
185-
try:
186-
method = getattr(value, "method", "UNKNOWN")
187-
request_path = getattr(value, "path", "UNKNOWN")
188-
new_values.append(
189-
f"HttpRequest({method} {request_path})"
190-
)
191-
except (AttributeError, ValueError, TypeError):
192-
new_values.append("HttpRequest(...)")
193-
else:
194-
new_values.append(value)
195-
else:
196-
new_values.append(value)
197-
attributes[key] = new_values
180+
for key, value_list in attributes.items():
181+
for i, value in enumerate(value_list):
182+
if isinstance(value, HttpRequest):
183+
try:
184+
method = getattr(value, "method", "UNKNOWN")
185+
request_path = getattr(value, "path", "UNKNOWN")
186+
value_list[i] = f"HttpRequest({method} {request_path})"
187+
except Exception:
188+
value_list[i] = "HttpRequest(...)"
198189
return attributes
199190

200191
@staticmethod

0 commit comments

Comments
 (0)