Board nrf52832 pinetime #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
And one more thing - I would argue about naming backlight LED's just 'ledN'. Though it shouldn't matter, for clarity sake I would suggest naming them 'blledN', like in the definition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, uh... Is making a pull request for the pull request a thing?
I wanted to add some changes to your pull request to the Zephyr upstream to make it more up-to-date. I'll go over them commit by commit.
SOC_FAMILY_NRFby hand in defconfing now produces a compilation error:Brief grep showed me that no other board sets it, so I guess it's safe and beneficial to remove it.
According to PineTime wiki entry and some brief googling, max speed at which you can use SPI on nRF52832 is 8MHz. So let's limit peripherals to this clock speed.
Now that Added generic shield for ST7789V display controller zephyrproject-rtos/zephyr#20570 is merged, there is a need for some more configuration for the display in the device tree. There was two example configs in this commit - I took one for 240x240 display, which is our case, and so does https://github.com/najnesnaj/pinetime-zephyr . It seems to work. Though I have no idea what those parameters mean.
Hope that those will help us to get those changes into upstream a bit faster.
Cheers.