Seal the internal traits

Author: alexkazik

src/dir.rs

@@ -15,6 +15,7 @@ use crate::dir_entry::{SFN_PADDING, SFN_SIZE};
 use crate::error::{Error, IoError};
 use crate::file::File;
 use crate::fs::{DiskSlice, FileSystem, FsIoAdapter, OemCpConverter, ReadWriteSeek};
+use crate::io::private::Sealed;
 use crate::io::{self, IoBase, Read, ReadFile, Seek, SeekFrom, Write, WriteFile};
 use crate::time::TimeProvider;
 
@@ -51,6 +52,8 @@ impl<IO: ReadWriteSeek, TP, OCC> Clone for DirRawStream<'_, IO, TP, OCC> {
     }
 }
 
+impl<IO: ReadWriteSeek, TP, OCC> Sealed for DirRawStream<'_, IO, TP, OCC> {}
+
 impl<IO: ReadWriteSeek, TP, OCC> IoBase for DirRawStream<'_, IO, TP, OCC> {
     type Error = Error<IO::Error>;
 }

src/file.rs

@@ -3,6 +3,7 @@ use core::convert::TryFrom;
 use crate::dir_entry::DirEntryEditor;
 use crate::error::Error;
 use crate::fs::{FileSystem, ReadWriteSeek};
+use crate::io::private::Sealed;
 use crate::io::{IoBase, Read, ReadFile, Seek, SeekFrom, Write, WriteFile};
 use crate::time::{Date, DateTime, TimeProvider};
 
@@ -250,6 +251,8 @@ impl<IO: ReadWriteSeek, TP, OCC> Clone for File<'_, IO, TP, OCC> {
     }
 }
 
+impl<IO: ReadWriteSeek, TP, OCC> Sealed for File<'_, IO, TP, OCC> {}
+
 impl<IO: ReadWriteSeek, TP, OCC> IoBase for File<'_, IO, TP, OCC> {
     type Error = Error<IO::Error>;
 }

src/fs.rs

@@ -13,6 +13,7 @@ use crate::dir::{Dir, DirRawStream};
 use crate::dir_entry::{DirFileEntryData, FileAttributes, SFN_PADDING, SFN_SIZE};
 use crate::error::Error;
 use crate::file::File;
+use crate::io::private::Sealed;
 use crate::io::{self, IoBase, Read, ReadFile, ReadLeExt, Seek, SeekFrom, Write, WriteFile, WriteLeExt};
 use crate::table::{
     alloc_cluster, count_free_clusters, format_fat, read_fat_flags, ClusterIterator, RESERVED_FAT_ENTRIES,
@@ -694,6 +695,8 @@ pub(crate) struct FsIoAdapter<'a, IO: ReadWriteSeek, TP, OCC> {
     fs: &'a FileSystem<IO, TP, OCC>,
 }
 
+impl<IO: ReadWriteSeek, TP, OCC> Sealed for FsIoAdapter<'_, IO, TP, OCC> {}
+
 impl<IO: ReadWriteSeek, TP, OCC> IoBase for FsIoAdapter<'_, IO, TP, OCC> {
     type Error = IO::Error;
 }
@@ -798,6 +801,8 @@ impl<B: Clone, S> Clone for DiskSlice<B, S> {
     }
 }
 
+impl<B, S: IoBase> Sealed for DiskSlice<B, S> {}
+
 impl<B, S: IoBase> IoBase for DiskSlice<B, S> {
     type Error = Error<S::Error>;
 }

src/io.rs

@@ -1,4 +1,5 @@
 use crate::error::IoError;
+use crate::io::private::Sealed;
 
 /// Provides IO error as an associated type.
 ///
@@ -9,6 +10,10 @@ pub trait IoBase {
     type Error: IoError;
 }
 
+pub(crate) mod private {
+    pub trait Sealed {}
+}
+
 /// The `Read` trait allows for reading bytes from a source.
 ///
 /// It is based on the `std::io::Read` trait.
@@ -34,7 +39,7 @@ pub trait Read: IoBase {
 /// The `ReadFile` trait allows for reading bytes from a source.
 ///
 /// It is based on the `std::io::Read` trait.
-pub trait ReadFile: Read {
+pub trait ReadFile: Read + Sealed {
     /// Pull some bytes from this source into the specified buffer, returning how many bytes were read.
     ///
     /// This function does not provide any guarantees about whether it blocks waiting for data, but if an object needs
@@ -125,7 +130,7 @@ pub trait Write: IoBase {
 /// The `WriteFile` trait allows for writing bytes into the sink.
 ///
 /// It is based on the `std::io::Write` trait.
-pub trait WriteFile: Write {
+pub trait WriteFile: Write + Sealed {
     /// Write a buffer into this writer, returning how many bytes were written.
     ///
     /// # Errors
@@ -243,6 +248,9 @@ impl<T> StdIoWrapper<T> {
     }
 }
 
+#[cfg(feature = "std")]
+impl<T> Sealed for StdIoWrapper<T> {}
+
 #[cfg(feature = "std")]
 impl<T> IoBase for StdIoWrapper<T> {
     type Error = std::io::Error;