Merged
Conversation
This is so that other tif files in the tempdir is not interfering with the Raster tests.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
+ Coverage 82.89% 83.72% +0.83%
==========================================
Files 58 68 +10
Lines 5425 5481 +56
==========================================
+ Hits 4497 4589 +92
+ Misses 928 892 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
We need that for rasterdatasources tests, but it is set in ci.yml, so not really a failure |
tiemvanderdeure
approved these changes
Nov 24, 2025
Contributor
Author
|
Could we set this somehow also locally. Because it is annoying to have local tests failures due to that. Could we instead of setting them via a yml as ENV["RASTERDATASOURCES_PATH"] from within julia in the tests that need it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #1047 by adding the force to the RasterCreator struct and so to be used as a keyword to rasterize.
I added the changes to test_utils, because I ran into test failures because I had a manually created tempname tif file in my temp folder which interfered with the RasterSeries tests. This adds a temporary dir so that every use of the temporary raster construction uses a separate folder.
Locally I get some seemingly unrelated failures due to some RASTERDATASOURCE variable not set in ENV. I don't understand why this failure comes up with these changes.