crop with Shapefile.Row fails

[felixcremer]

Trying to crop a Raster with a Shapefile.Table works, but when I select a single row from that Table it fails with the following error:

julia> crop(s1_cube_asc, to=farm)
ERROR: MethodError: no method matching length(::Shapefile.Row{Shapefile.Polygon})
The function `length` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  length(::DataStructures.SparseIntSet)
   @ DataStructures ~/.julia/packages/DataStructures/IrAJn/src/sparse_int_set.jl:61
  length(::Markdown.MD)
   @ Markdown ~/.julia/juliaup/julia-1.11.4+0.x64.linux.gnu/share/julia/stdlib/v1.11/Markdown/src/parse/parse.jl:37
  length(::Distributions.DirichletStats)
   @ Distributions ~/.julia/packages/Distributions/qRkAO/src/multivariate/dirichlet.jl:186
  ...

Stacktrace:
 [1] _similar_shape(itr::Shapefile.Row{Shapefile.Polygon}, ::Base.HasLength)
   @ Base ./array.jl:663
 [2] _collect(cont::UnitRange{Int64}, itr::Shapefile.Row{Shapefile.Polygon}, ::Base.HasEltype, isz::Base.HasLength)
   @ Base ./array.jl:722
 [3] collect(itr::Shapefile.Row{Shapefile.Polygon})
   @ Base ./array.jl:716
 [4] _get_geometries(data::Shapefile.Row{Shapefile.Polygon}, ::Nothing)
   @ Rasters ~/.julia/packages/Rasters/UTSRc/src/utils.jl:259
 [5] _extent(data::Shapefile.Row{Shapefile.Polygon}; geometrycolumn::Nothing, kw::@Kwargs{})
   @ Rasters ~/.julia/packages/Rasters/UTSRc/src/methods/burning/extents.jl:5
 [6] _crop_to(x::Raster{…}, to::Shapefile.Row{…}; geometrycolumn::Nothing, kw::@Kwargs{})
   @ Rasters ~/.julia/packages/Rasters/UTSRc/src/methods/crop_extend.jl:87
 [7] _crop_to(x::Raster{…}, to::Shapefile.Row{…})
   @ Rasters ~/.julia/packages/Rasters/UTSRc/src/methods/crop_extend.jl:86
 [8] crop(x::Raster{…}; to::Shapefile.Row{…}, kw::@Kwargs{})
   @ Rasters ~/.julia/packages/Rasters/UTSRc/src/methods/crop_extend.jl:83
 [9] top-level scope
   @ REPL[55]:1
Some type information was truncated. Use `show(err)` to see complete types.

[tiemvanderdeure]

Is this on the latest release?

If so, it must be because it has no GeoInterface trait. What does GI.trait return? I guess it should be a FeatureTrait

[tiemvanderdeure]

Just checked and Shapefile just doesn't implement GI.trait (neither for tables nor for rows - I'm not sure why this even works for the whole table). I'll make a PR there.

[rafaqz]

Yeah, Shapefile.jl issue.

But not sure we can handle other table rows either?

[tiemvanderdeure]

If you GeoInterace is implemented, or if they have a geometry column we do handle it. That's what the geometrycolumn keyword is for

[tiemvanderdeure]

Actually this is why it worked with a Shapefile table even if it didn't impelement GeoInterface.trait. It was a table, and it has a :geometry column, and so Tables.getcolumn(Tables.columns(data), geomcol) just returns the geometries fine.

But probably we should revert this order. If something is both a GI.AbstractFeatureCollection and a table, probably we should treat it as a feature collection and get the geometries with [GI.geometry(f) for f in GI.getfeature(data)]?

[rafaqz]

GI.getfeature implies loading the whole row, where for a column wise table we just load the geoms.

Basically Tables.jl has a more efficient interface

[tiemvanderdeure]

Okay, so let's leave it as it is.

I think for most table rows we're all good, since (geometry = (1,1), a = 2) |> GeoInterface.trait returns GeoInterface.FeatureTrait(). So it's only if packages implement their own row types that they need to implement the GI interface.

[rafaqz]

Hm maybe Tables.jl has a row interface?

[asinghvi17]

It does, I had a PR to make these featurecollections/features but don't remember why it didn't go through.

[rafaqz]

JuliaGeo/GeoInterface.jl#156

Yea just need to fix some test.

Looks like we have been neglecting GI PRs a bit, I also have a few dead ones there 😭

[rafaqz]

Not a Rasters issue, so closing

[tiemvanderdeure]

It should also be solved if you're on Shapefile#main