Fix crash when booking additional appointments (#19)

Signed-off-by: rafsaf <rafal.safin12@gmail.com>

Author: rafsaf

medichaser.py

@@ -869,9 +869,12 @@ def format_appointments(appointments: list[dict[str, Any]]) -> str:
         messages = []
         for appointment in appointments:
             date = appointment.get("appointmentDate", "N/A")
-            clinic = appointment.get("clinic", {}).get("name", "N/A")
-            doctor = appointment.get("doctor", {}).get("name", "N/A")
-            specialty = appointment.get("specialty", {}).get("name", "N/A")
+            clinic_info = appointment.get("clinic", {}) or {}
+            clinic = clinic_info.get("name", "N/A")
+            doctor_info = appointment.get("doctor", {}) or {}
+            doctor = doctor_info.get("name", "N/A")
+            specialty_info = appointment.get("specialty", {}) or {}
+            specialty = specialty_info.get("name", "N/A")
             doctor_languages = appointment.get("doctorLanguages", [])
             languages = (
                 ", ".join([lang.get("name", "N/A") for lang in doctor_languages])
@@ -946,9 +949,12 @@ def display_appointments(appointments: list[dict[str, Any]]) -> None:
         log.info("--------------------------------------------------")
         for appointment in appointments:
             date = appointment.get("appointmentDate", "N/A")
-            clinic = appointment.get("clinic", {}).get("name", "N/A")
-            doctor = appointment.get("doctor", {}).get("name", "N/A")
-            specialty = appointment.get("specialty", {}).get("name", "N/A")
+            clinic_info = appointment.get("clinic", {}) or {}
+            clinic = clinic_info.get("name", "N/A")
+            doctor_info = appointment.get("doctor", {}) or {}
+            doctor = doctor_info.get("name", "N/A")
+            specialty_info = appointment.get("specialty", {}) or {}
+            specialty = specialty_info.get("name", "N/A")
             doctor_languages = appointment.get("doctorLanguages", [])
             languages = (
                 ", ".join([lang.get("name", "N/A") for lang in doctor_languages])

tests.py

@@ -602,6 +602,24 @@ def test_format_appointments_multiple(self) -> None:
         assert "Languages: N/A" in result  # First appointment has no languages
         assert "Languages: Polish" in result  # Second appointment has Polish
 
+    def test_format_appointments_none_nested_objects(self) -> None:
+        """Test formatting when clinic/doctor/specialty are None."""
+        appointments: list[dict[str, Any]] = [
+            {
+                "appointmentDate": "2025-01-03T09:00:00",
+                "clinic": None,
+                "doctor": None,
+                "specialty": None,
+                "doctorLanguages": [],
+            }
+        ]
+
+        result = Notifier.format_appointments(appointments)
+
+        assert "Clinic: N/A" in result
+        assert "Doctor: N/A" in result
+        assert "Specialty: N/A" in result
+
     def test_send_notification_pushbullet(
         self, monkeypatch: pytest.MonkeyPatch
     ) -> None:
@@ -779,6 +797,29 @@ def test_display_appointments_with_data(
         mock_log.info.assert_any_call("New appointments found:")
         mock_log.info.assert_any_call("Date: 2025-01-01T10:00:00")
 
+    def test_display_appointments_none_nested_objects(
+        self, monkeypatch: pytest.MonkeyPatch
+    ) -> None:
+        """Test display_appointments when clinic/doctor/specialty are None."""
+        mock_log = Mock()
+        monkeypatch.setattr("medichaser.log", mock_log)
+
+        appointments: list[dict[str, Any]] = [
+            {
+                "appointmentDate": "2025-01-03T09:00:00",
+                "clinic": None,
+                "doctor": None,
+                "specialty": None,
+                "doctorLanguages": [],
+            }
+        ]
+
+        display_appointments(appointments)
+
+        mock_log.info.assert_any_call("  Clinic: N/A")
+        mock_log.info.assert_any_call("  Doctor: N/A")
+        mock_log.info.assert_any_call("  Specialty: N/A")
+
 
 class TestNotificationFunctions:
     """Test cases for notification functions."""