Revert "- Remove the uploaded files state as a condition for whether the submit button is enabled"

This reverts commit 4ebcfc3.

Author: elipe17

tdrs-frontend/cypress/e2e/common-steps/data_files.js

@@ -24,6 +24,9 @@ export const uploadFile = (file_input, file_path, willError = false) => {
       'exist'
     )
     cy.get('.usa-alert__text').should('not.exist')
+    cy.get('button')
+      .contains('Submit')
+      .should('not.be.disabled', { timeout: 5000 })
   }
 }
 
@@ -198,7 +201,10 @@ export const uploadSectionFile = (
       'is-loading'
     )
     cy.get('.usa-alert__text').should('not.exist')
-    cy.contains('button', 'Submit').click()
+    cy.get('button')
+      .contains('Submit')
+      .should('not.be.disabled', { timeout: 5000 })
+    cy.contains('button', 'Submit').should('be.enabled').click()
     cy.wait('@dataFileSubmit', { timeout: 60000 }).then(({ response }) => {
       const id = response?.body?.id
       if (!id) throw new Error('Missing data_file id in response')

tdrs-frontend/src/components/FileUploadForms/QuarterFileUploadForm.jsx

@@ -113,7 +113,7 @@ const QuarterFileUploadForm = ({ stt }) => {
           <Button
             className="card:margin-y-1"
             type="submit"
-            disabled={isSubmitting}
+            disabled={isSubmitting || uploadedFiles.length === 0}
           >
             {isSubmitting ? 'Submitting...' : 'Submit Data Files'}
           </Button>

tdrs-frontend/src/components/FileUploadForms/QuarterFileUploadForm.test.js

@@ -139,26 +139,18 @@ describe('QuarterFileUploadForm', () => {
   })
 
   describe('Form Submission', () => {
-    it('shows error alert when submitting with no uploaded files', async () => {
+    it('does not allow submission with no uploaded files', async () => {
       const storeState = {
         ...initialState,
         reports: {
           submittedFiles: [],
         },
       }
 
-      const { getByText, getByRole } = renderComponent(storeState)
+      const { getByText } = renderComponent(storeState)
 
       const submitButton = getByText('Submit Data Files')
-      fireEvent.click(submitButton)
-
-      await waitFor(() => {
-        const alert = getByRole('alert')
-        expect(alert).toBeInTheDocument()
-        expect(alert).toHaveTextContent(
-          'No changes have been made to data files'
-        )
-      })
+      expect(submitButton).not.toBeEnabled()
 
       expect(mockExecuteSubmission).not.toHaveBeenCalled()
     })

tdrs-frontend/src/components/FileUploadForms/SectionFileUploadForm.jsx

@@ -100,7 +100,7 @@ const SectionFileUploadForm = ({ stt }) => {
           <Button
             className="card:margin-y-1"
             type="submit"
-            disabled={isSubmitting}
+            disabled={isSubmitting || uploadedFiles.length === 0}
           >
             {isSubmitting ? 'Submitting...' : 'Submit Data Files'}
           </Button>

tdrs-frontend/src/components/FileUploadForms/SectionFileUploadForm.test.js

@@ -176,26 +176,18 @@ describe('SectionFileUploadForm', () => {
   })
 
   describe('Form Submission', () => {
-    it('shows error alert when submitting with no uploaded files', async () => {
+    it('does not allow submission with no uploaded files', async () => {
       const storeState = {
         ...initialState,
         reports: {
           submittedFiles: [],
         },
       }
 
-      const { getByText, getByRole } = renderComponent(storeState)
+      const { getByText } = renderComponent(storeState)
 
       const submitButton = getByText('Submit Data Files')
-      fireEvent.click(submitButton)
-
-      await waitFor(() => {
-        const alert = getByRole('alert')
-        expect(alert).toBeInTheDocument()
-        expect(alert).toHaveTextContent(
-          'No changes have been made to data files'
-        )
-      })
+      expect(submitButton).not.toBeEnabled()
 
       expect(mockExecuteSubmission).not.toHaveBeenCalled()
     })

tdrs-frontend/src/components/Reports/FRAReports.jsx

@@ -271,15 +271,6 @@ const UploadForm = ({
       return
     }
 
-    if (!file || (file && file.id)) {
-      setLocalAlertState({
-        active: true,
-        type: 'error',
-        message: 'No changes have been made to data files',
-      })
-      return
-    }
-
     handleUpload({ file })
   }
 
@@ -333,7 +324,7 @@ const UploadForm = ({
           <Button
             className="card:margin-y-1"
             type="submit"
-            disabled={isSubmitting}
+            disabled={isSubmitting || fraHasUploadedFile === false}
           >
             {isSubmitting ? 'Submitting...' : 'Submit Report'}
           </Button>

tdrs-frontend/src/components/Reports/FRAReports.test.js

@@ -504,13 +504,7 @@ describe('FRA Reports Page', () => {
       const { getByText } = await setup()
 
       const submitButton = getByText('Submit Report', { selector: 'button' })
-      fireEvent.click(submitButton)
-
-      await waitFor(() =>
-        expect(
-          getByText('No changes have been made to data files')
-        ).toBeInTheDocument()
-      )
+      expect(submitButton).not.toBeEnabled()
     })
 
     it('Shows an error if a non-allowed file type is selected', async () => {

tdrs-frontend/src/components/Reports/Reports.test.js

@@ -407,9 +407,8 @@ describe('Reports', () => {
     await waitFor(() => expect(getByText('section2.txt')).toBeInTheDocument())
     await waitFor(() => expect(getByText('section3.txt')).toBeInTheDocument())
     await waitFor(() => expect(getByText('section4.txt')).toBeInTheDocument())
-    await waitFor(() =>
-      expect(store.dispatch).toHaveBeenCalledTimes(14)
-    )
+    await waitFor(() => expect(getByText('Submit Data Files')).toBeEnabled())
+    expect(store.dispatch).toHaveBeenCalledTimes(14)
 
     fireEvent.click(getByText('Submit Data Files'))
     await waitFor(() => getByRole('alert'))

tdrs-frontend/src/hooks/useFileUploadForm.js

@@ -110,15 +110,6 @@ export const useFileUploadForm = ({
   const onSubmit = async (event) => {
     event.preventDefault()
 
-    if (uploadedFiles.length === 0) {
-      setLocalAlertState({
-        active: true,
-        type: 'error',
-        message: 'No changes have been made to data files',
-      })
-      return
-    }
-
     try {
       // Transform files if needed (e.g., for Program Audit)
       const filesToSubmit = transformFiles