Skip to content

Commit 72cc971

Browse files
authored
fix: make domain validation less restrictive for extension deployments (#543)
1 parent f3eae1b commit 72cc971

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

api/api/versions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{
44
"version": "v1",
55
"status": "active",
6-
"release_date": "2025-10-28T22:04:41.913593+05:30",
6+
"release_date": "2025-10-29T21:35:21.229737201+05:30",
77
"end_of_life": "0001-01-01T00:00:00Z",
88
"changes": [
99
"Initial API version"

api/internal/features/extension/engine/proxy.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,23 +57,23 @@ func (proxyModule) Execute(sshClient *ssh.SSH, step types.SpecStep, vars map[str
5757
switch action {
5858
case "add":
5959
if domain == "" || port == "" {
60-
return "", nil, fmt.Errorf("domain and port are required")
60+
return "proxy step skipped: domain and port are optional", nil, nil
6161
}
6262
if err := AddDomainToProxy(domain, port); err != nil {
6363
return "", nil, err
6464
}
6565
return fmt.Sprintf("proxy added for %s -> %s:%s", domain, config.AppConfig.SSH.Host, port), nil, nil
6666
case "update":
6767
if domain == "" || port == "" {
68-
return "", nil, fmt.Errorf("domain and port are required")
68+
return "proxy step skipped: domain and port are optional", nil, nil
6969
}
7070
if err := UpdateDomainInProxy(domain, port); err != nil {
7171
return "", nil, err
7272
}
7373
return fmt.Sprintf("proxy updated for %s -> %s:%s", domain, config.AppConfig.SSH.Host, port), nil, nil
7474
case "remove":
7575
if domain == "" {
76-
return "", nil, fmt.Errorf("domain is required")
76+
return "proxy step skipped: domain is optional", nil, nil
7777
}
7878
if err := RemoveDomainFromProxy(domain); err != nil {
7979
return "", nil, err

api/internal/features/extension/parser/validate.go

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,8 @@ func (p *Parser) validateProxyStep(step ExecutionStep) error {
156156
}
157157
action, _ := step.Properties["action"].(string)
158158
switch action {
159-
case "add", "update":
160-
return p.requireProps(step, map[string]bool{"domain": true, "port": true})
161-
case "remove":
162-
return p.requireProps(step, map[string]bool{"domain": true})
159+
case "add", "update", "remove":
160+
return nil
163161
default:
164162
return fmt.Errorf("unsupported proxy action: %s", action)
165163
}

0 commit comments

Comments
 (0)