settings bean disableCache value is not honoured

[pgokul]

The settings bean globalSSMSettings is queried after the caches have been created in cacheBase afterPropertiesSet. This effectively results in globalSSMSettings disableCache not being honored.

[ragnor]

Have you noticed any request to the memcached when the disableCache property is set to true?

When disableCache property is set some SSM classes/beans are still initialized but there are no request to memcached instance. Take a look at CacheFactory. It creates Cache but the created object is only stub of the Cache. Also each *Advice class (e.g. SingleReadCacheAdvice) before applying a caching to a method checks if cache is disabled.

[pgokul]

we noticed connections to memcached server were happening. In our case when we disable cache the memcache endpoint is also invalid so we can see a lot of connection errors.
The cache factory stub cache is not created since the settings object is read after the cache creation.

[ragnor]

Does it change anything if you use system property ssm.cache.disable=true instead of globallSSMSettings?

[pgokul]

yes. connections to the memcached server were not happening if the property ssm.cache.disable=true was set.

[ragnor]

Thank you for the patch. It has been merged to master.

[jamsesso]

Would it be possible to release this patch in a revision release instead of waiting for 3.7.0 because it is a bug fix and not new functionality?