Run cargo fmt and fix all warnings, including ones from clippy (#19)

* Run `cargo fmt`

* Fix clippy warnings.

Author: AldaronLau

examples/blink.rs

@@ -7,7 +7,7 @@ fn main() {
     let mut led = LED::new(17);
 
     // on_time = 2 secs, off_time=3 secs
-    led.blink(2.0,3.0);
+    led.blink(2.0, 3.0);
 
     // prevent program from exiting immediately
     led.wait();

examples/servo.rs

@@ -1,20 +1,28 @@
 use rust_gpiozero::*;
 use std::io;
 use std::io::prelude::*;
+use std::sync::atomic::{AtomicBool, Ordering};
 use std::thread;
 use std::time::Duration;
 
+static RUNNING: AtomicBool = AtomicBool::new(true);
+
+fn watch_stdin() {
+    // wait for key press to exit
+    let _ = io::stdin().read(&mut [0u8]).unwrap();
+    RUNNING.store(false, Ordering::Relaxed);
+}
+
 fn main() {
+    std::thread::spawn(watch_stdin);
+
     // Create a new Servo attached to Pin 23
     let mut servo = Servo::new(23);
 
-    loop{
+    while RUNNING.load(Ordering::Relaxed) {
         servo.max();
-        thread::sleep(Duration::from_millis(2000));
+        thread::sleep(Duration::from_millis(2_000));
         servo.min();
-        thread::sleep(Duration::from_millis(2000));
+        thread::sleep(Duration::from_millis(2_000));
     }
-
-    // wait for key press to exit
-    let _ = io::stdin().read(&mut [0u8]).unwrap();
 }

src/devices.rs

@@ -11,18 +11,19 @@ pub trait Device {
     /// Returns ``True`` if the device is currently active and ``False`` otherwise.
     fn is_active(&self) -> bool;
 }
+
 #[macro_export]
 macro_rules! impl_device {
     () => {
-    /// Returns ``True`` if the device is currently active and ``False`` otherwise.
-    pub fn is_active(&self) -> bool {
-        self.value()
-    }
-    /// Shut down the device and release all associated resources.
-    pub fn close(self) {
-        drop(self)
-    }
-    }
+        /// Returns ``True`` if the device is currently active and ``False`` otherwise.
+        pub fn is_active(&self) -> bool {
+            self.value()
+        }
+        /// Shut down the device and release all associated resources.
+        pub fn close(self) {
+            drop(self)
+        }
+    };
 }
 
 /// Represents a generic GPIO device and provides the services common to all single-pin GPIO devices
@@ -35,20 +36,18 @@ pub struct GpioDevice {
 
 macro_rules! impl_gpio_device {
     () => {
-    /// The `Pin` that the device is connected to.
-    pub fn pin(&self) -> u8 {
-        self.pin.pin()
-    }
-
-    }
+        /// The `Pin` that the device is connected to.
+        pub fn pin(&self) -> u8 {
+            self.pin.pin()
+        }
+    };
 }
 
 impl GpioDevice {
     /// Returns a GpioDevice with the pin number given
     /// # Arguments
     ///
     /// * `pin` - The GPIO pin which the device is attached to
-    ///
     pub fn new(pin: u8) -> GpioDevice {
         match Gpio::new() {
             Err(e) => panic!("{:?}", e),

src/input_devices.rs

@@ -60,29 +60,33 @@ impl InputDevice {
 macro_rules! impl_events_mixin {
     () => {
         /// Pause the program until the device is activated, or the timeout is reached.
-        fn wait_for(&mut self, timeout:Option<f32>, active: bool){
-            match timeout{
-                None =>
+        fn wait_for(&mut self, timeout: Option<f32>, active: bool) {
+            match timeout {
+                None => {
                     if active {
                         self.pin.set_interrupt(Trigger::RisingEdge).unwrap();
                         self.pin.poll_interrupt(true, None).unwrap();
-                    }else{
+                    } else {
                         self.pin.set_interrupt(Trigger::FallingEdge).unwrap();
                         self.pin.poll_interrupt(true, None).unwrap();
                     }
-                ,
-                Some(n) => if active {
+                }
+                Some(n) => {
+                    if active {
                         self.pin.set_interrupt(Trigger::RisingEdge).unwrap();
-                        self.pin.poll_interrupt(true, Some(Duration::from_millis((n * 1000.0) as u64))).unwrap();
-                    }else{
+                        self.pin
+                            .poll_interrupt(true, Some(Duration::from_millis((n * 1000.0) as u64)))
+                            .unwrap();
+                    } else {
                         self.pin.set_interrupt(Trigger::FallingEdge).unwrap();
-                        self.pin.poll_interrupt(true, Some(Duration::from_millis((n * 1000.0) as u64))).unwrap();
+                        self.pin
+                            .poll_interrupt(true, Some(Duration::from_millis((n * 1000.0) as u64)))
+                            .unwrap();
                     }
+                }
             }
         }
-
-
-    }
+    };
 }
 
 /// Represents a generic input device with typical on/off behaviour.
@@ -167,6 +171,8 @@ pub struct Button {
     pin: InputPin,
     active_state: bool,
     inactive_state: bool,
+    // FIXME: Implement debouncing
+    #[allow(dead_code)]
     bounce_time: Option<f32>,
 }
 

src/lib.rs

@@ -19,20 +19,13 @@
 //! ```
 //! use rust_gpiozero::*;
 //!
-//! fn main() {
-//!
 //! // Create a new LED attached to Pin 17
-//!
 //! let mut led = LED::new(17);
 //!
 //! // blink the LED
 //! // on_time: 2 seconds and off_time: 3 seconds
-//!
 //! led.blink(2.0,3.0);
-//!
-//! }
 //! ```
-//!
 
 pub use self::devices::*;
 pub use self::input_devices::*;