Skip to content

Commit 933b6d9

Browse files
benjaminglass1pytorchmergebot
authored andcommitted
cpp_wrapper: enable in aarch64 and x86 nightly dashboard performance runs (pytorch#145791)
Adds `cpp_wrapper` mode to the nightly inductor benchmark runs, as well as optionally for manually triggered runs. This is justified by `aot_inductor` already being in those runs. Additionally, re-enables `aot_inductor` in the nightly aarch64 runs. It was disabled 5 months ago to deal with a performance instability, which has likely gone away at this point. Pull Request resolved: pytorch#145791 Approved by: https://github.com/desertfire
1 parent 32bb6f8 commit 933b6d9

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

.github/workflows/inductor-perf-test-nightly-aarch64.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ name: inductor-perf-nightly-aarch64
22

33
on:
44
schedule:
5-
# - cron: 0 7 * * 1-6
6-
# - cron: 0 7 * * 0
75
# Does not perform max_autotune on CPU, so skip the weekly run setup
86
- cron: 0 7 * * *
97
# NB: GitHub has an upper limit of 10 inputs here
@@ -30,6 +28,11 @@ on:
3028
required: false
3129
type: boolean
3230
default: false
31+
cppwrapper:
32+
description: Run inductor_cpp_wrapper?
33+
required: false
34+
type: boolean
35+
default: false
3336
aotinductor:
3437
description: Run aot_inductor for inference?
3538
required: false
@@ -117,9 +120,7 @@ jobs:
117120
if: github.event.schedule == '0 7 * * *'
118121
with:
119122
build-environment: linux-jammy-aarch64-py3.10
120-
# Turn off dynamic-shapes and aotinductor tests for now, to have faster iteration for debugging perf instability.
121-
# Will change this back
122-
dashboard-tag: training-false-inference-true-default-true-dynamic-false-aotinductor-false
123+
dashboard-tag: training-false-inference-true-default-true-dynamic-true-cppwrapper-true-aotinductor-true
123124
docker-image: ${{ needs.linux-jammy-aarch64-py3_10-inductor-build.outputs.docker-image }}
124125
test-matrix: ${{ needs.linux-jammy-aarch64-py3_10-inductor-build.outputs.test-matrix }}
125126
timeout-minutes: 720
@@ -135,7 +136,7 @@ jobs:
135136
if: github.event_name == 'workflow_dispatch'
136137
with:
137138
build-environment: linux-jammy-aarch64-py3.10
138-
dashboard-tag: training-${{ inputs.training }}-inference-${{ inputs.inference }}-default-${{ inputs.default }}-dynamic-${{ inputs.dynamic }}-aotinductor-${{ inputs.aotinductor }}
139+
dashboard-tag: training-${{ inputs.training }}-inference-${{ inputs.inference }}-default-${{ inputs.default }}-dynamic-${{ inputs.dynamic }}-cppwrapper-${{ inputs.cppwrapper }}-aotinductor-${{ inputs.aotinductor }}
139140
docker-image: ${{ needs.linux-jammy-aarch64-py3_10-inductor-build.outputs.docker-image }}
140141
test-matrix: ${{ needs.linux-jammy-aarch64-py3_10-inductor-build.outputs.test-matrix }}
141142
timeout-minutes: 720

.github/workflows/inductor-perf-test-nightly-x86.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,11 @@ on:
3030
required: false
3131
type: boolean
3232
default: false
33+
cppwrapper:
34+
description: Run inductor_cpp_wrapper?
35+
required: false
36+
type: boolean
37+
default: false
3338
aotinductor:
3439
description: Run aot_inductor for inference?
3540
required: false
@@ -92,7 +97,7 @@ jobs:
9297
if: github.event.schedule == '0 7 * * *'
9398
with:
9499
build-environment: linux-jammy-py3.9-gcc11-build
95-
dashboard-tag: training-false-inference-true-default-true-dynamic-true-aotinductor-true
100+
dashboard-tag: training-false-inference-true-default-true-dynamic-true-cppwrapper-true-aotinductor-true
96101
docker-image: ${{ needs.linux-jammy-cpu-py3_9-gcc11-inductor-build.outputs.docker-image }}
97102
test-matrix: ${{ needs.linux-jammy-cpu-py3_9-gcc11-inductor-build.outputs.test-matrix }}
98103
timeout-minutes: 720
@@ -108,7 +113,7 @@ jobs:
108113
if: github.event_name == 'workflow_dispatch'
109114
with:
110115
build-environment: linux-jammy-py3.9-gcc11-build
111-
dashboard-tag: training-${{ inputs.training }}-inference-${{ inputs.inference }}-default-${{ inputs.default }}-dynamic-${{ inputs.dynamic }}-aotinductor-${{ inputs.aotinductor }}
116+
dashboard-tag: training-${{ inputs.training }}-inference-${{ inputs.inference }}-default-${{ inputs.default }}-dynamic-${{ inputs.dynamic }}-cppwrapper-${{ inputs.cppwrapper }}-aotinductor-${{ inputs.aotinductor }}
112117
docker-image: ${{ needs.linux-jammy-cpu-py3_9-gcc11-inductor-build.outputs.docker-image }}
113118
test-matrix: ${{ needs.linux-jammy-cpu-py3_9-gcc11-inductor-build.outputs.test-matrix }}
114119
timeout-minutes: 720

0 commit comments

Comments
 (0)