Skip to content

external visibility is sufficient instead of public visibility #137

@ethers

Description

@ethers

In auction.sol (and potentially other files), is there a reason why functions like setup(), addToWhitelist() etc are public instead of external? They are not being called internally, so external visibility is sufficient.

https://github.com/ConsenSys/smart-contract-best-practices#explicitly-mark-visibility-in-functions-and-state-variables

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions