fixing array rendering when elements doesn't have a serializer

Author: joaomdmoura

lib/action_controller/serialization.rb

@@ -39,17 +39,19 @@ def use_adapter?
           options.partition { |k, _| ADAPTER_OPTION_KEYS.include? k }.map { |h| Hash[h] }
 
         if use_adapter? && (serializer = get_serializer(resource))
-
           @_serializer_opts[:scope] ||= serialization_scope
           @_serializer_opts[:scope_name] = _serialization_scope
 
-          # omg hax
-          object = serializer.new(resource, @_serializer_opts)
-          adapter = ActiveModel::Serializer::Adapter.create(object, @_adapter_opts)
-          super(adapter, options)
-        else
-          super(resource, options)
+          object   = serializer.new(resource, @_serializer_opts)
+
+          if serializer == ActiveModel::Serializer.config.array_serializer
+            resource = ActiveModel::Serializer::Adapter.create(object, @_adapter_opts) unless object.objects.all? {|i| i.nil?}
+          else
+            resource = ActiveModel::Serializer::Adapter.create(object, @_adapter_opts)
+          end
         end
+
+        super(resource, options)
       end
     end
 

lib/active_model/serializer/array_serializer.rb

@@ -4,7 +4,7 @@ class ArraySerializer
       include Enumerable
       delegate :each, to: :@objects
 
-      attr_reader :meta, :meta_key
+      attr_reader :meta, :meta_key, :objects
 
       def initialize(objects, options = {})
         @resource = objects
@@ -13,7 +13,10 @@ def initialize(objects, options = {})
             :serializer,
             ActiveModel::Serializer.serializer_for(object)
           )
-          serializer_class.new(object, options.except(:serializer))
+
+          unless serializer_class.nil?
+            serializer_class.new(object, options.except(:serializer))
+          end
         end
         @meta     = options[:meta]
         @meta_key = options[:meta_key]