test(ci): github (#2447)

* test(ci): github

* test: try to mimic travis a bit

* Change ci ruby 2.5 matrix to use rails-version 4.2 instead

* Update gemfile to lock loofah gem version to be less than 2.21 for older ruby versions

* Add backwards compatibility for rails-controller-testing on initialization

* Add new ci matrix for ruby 2.5 and rails 5.2

* Fix failing test due to mismatch test output

* Remove rails version older than 4.2 from ci matrix

* Add ruby 2.7 and 2.6 to ci matrix

---------

Co-authored-by: Loh Wei Jun <[email protected]>

Author: bf4

.github/workflows/ci.yml

@@ -0,0 +1,77 @@
+---
+
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    name: Ruby ${{ matrix.ruby-version }} Rails ${{ matrix.rails-version }}
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          # Recent Rubies and Rails
+          # - ruby-version: '3.1'
+          #   rails-version: '7.0'
+          # - ruby-version: '3.0'
+          #   rails-version: '7.0'
+          # - ruby-version: '2.7'
+          #   rails-version: '7.0'
+          # - ruby-version: '2.6'
+          #   rails-version: '6.1'
+          # - ruby-version: '2.6'
+          #   rails-version: '6.0'
+          # - ruby-version: '2.7'
+          #   rails-version: '6.0'
+          # - ruby-version: '2.6'
+          #   rails-version: '5.2'
+          # Old Rubies and Rails
+          - ruby-version: '2.7'
+            rails-version: '5.2'
+          - ruby-version: '2.6'
+            rails-version: '5.2'
+          - ruby-version: '2.5'
+            rails-version: '5.2'
+          - ruby-version: '2.5'
+            rails-version: '4.2'
+            bundler: '1'
+          - ruby-version: '2.4'
+            rails-version: '5.2'
+            bundler: '1'
+          - ruby-version: '2.4'
+            rails-version: '4.2'
+            bundler: '1'
+#          - ruby-version: '2.4'
+#            rails-version: '4.1'
+#            bundler: '1'
+#          - ruby-version: '2.4'
+#            rails-version: '4.0'
+#            bundler: '1'
+
+    continue-on-error: "${{ endsWith(matrix.ruby-version, 'head') }}"
+
+    env:
+      CI: "1"
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+
+    steps:
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - uses: actions/checkout@v3
+
+      - name: "Build Ruby"
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version:   "${{ matrix.ruby-version }}"
+          bundler:        "${{ matrix.bundler || 2 }}"
+          bundler-cache:  true
+        env:
+          RAILS_VERSION: ${{ matrix.rails-version }}
+
+      - name: "Run tests"
+        run: |
+          bundle exec rake
+        env:
+          RAILS_VERSION: ${{ matrix.rails-version }}

Gemfile

@@ -36,6 +36,9 @@ if RUBY_VERSION < '2'
 end
 
 if ENV['CI']
+  # loofah has a breaking change 2.21 onwards which does not work with < 2.5 ruby
+  gem 'loofah', '< 2.21' if RUBY_VERSION < '2.5'
+
   if RUBY_VERSION < '2.4'
     # Windows: An error occurred while installing nokogiri (1.8.0)
     gem 'nokogiri', '< 1.7', platforms: @windows_platforms

test/test_helper.rb

@@ -2,8 +2,13 @@
 require 'minitest/autorun'
 require 'active_model_serializers'
 require 'fixtures/poro'
-require 'rails-controller-testing'
-Rails::Controller::Testing.install
+begin
+  require 'rails-controller-testing'
+  Rails::Controller::Testing.install
+rescue LoadError
+  false # Rails 5 < backward compatibility
+end
+
 
 # Ensure backward compatibility with Minitest 4
 Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)

test/unit/active_model/array_serializer/serialization_test.rb

@@ -66,8 +66,8 @@ def test_namespace
         serializer = ArraySerializer.new(array)
 
         expected = [
-          { name: 'Test 1', email: '[email protected]', sub_test: { name: 'Name 1', description: 'Description 1' }},
-          { name: 'Test 1', email: '[email protected]', sub_test: { name: 'Name 2', description: 'Description 2' }}
+          { name: 'Test 1', email: '[email protected]', sub_test: { name: 'Name 1', description: 'Description 1' } },
+          { name: 'Test 2', email: '[email protected]', sub_test: { name: 'Name 2', description: 'Description 2' } }
         ]
 
         assert_equal expected, serializer.serializable_array