Skip to content

Commit 65cf7d4

Browse files
committed
Add suggestions from João
1 parent 89ebba2 commit 65cf7d4

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
## How can I help?
22

3+
Everyone is encouraged to open issues that are affecting you: bugs, ideas, performance problems – everything helps!
4+
35
The first place to start is by looking at our [GitHub Issues](https://github.com/rails-api/active_model_serializers/issues).
46

57
The vast majority of development is happening under the `master` branch, currently slated for release as `0.10.x`. This is where we would suggest you start.
@@ -20,6 +22,10 @@ AMS uses a subset of [StandardIssueLabels](https://github.com/wagenet/StandardIs
2022

2123
1. Fork it ( https://github.com/rails-api/active_model_serializers/fork )
2224
2. Create your feature branch (`git checkout -b my-new-feature`)
23-
3. Commit your changes (`git commit -am 'Add some feature'`)
24-
4. Push to the branch (`git push origin my-new-feature`)
25-
5. Create a new Pull Request
25+
3. Write tests for your feature, or regression tests highlighting a bug
26+
4. Write the feature itself, or fix your bug
27+
5. Commit your changes (`git commit -am 'Add some feature'`)
28+
6. Push to the branch (`git push origin my-new-feature`)
29+
7. Create a new Pull Request
30+
31+
Remember to squash your commits and rebase off `master`.

0 commit comments

Comments
 (0)