re: RuboCop - replace rocket style hashes

dubadub · dubadub · commit 800221ed90f2 · 2016-06-21T22:08:27.000+01:00
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.1
   Exclude:
     - config/initializers/forbidden_yaml.rb
     - !ruby/regexp /(vendor|bundle|bin|db|tmp)\/.*/
diff --git a/test/active_model_serializers/key_transform_test.rb b/test/active_model_serializers/key_transform_test.rb
@@ -6,7 +6,7 @@ def test_camel
       obj = Object.new
       scenarios = [
         {
-          value: { "some-key": 'value' },
+          value: { :"some-key" => 'value' },
           expected: { SomeKey: 'value' }
         },
         {
@@ -72,7 +72,7 @@ def test_camel_lower
       obj = Object.new
       scenarios = [
         {
-          value: { "some-key": 'value' },
+          value: { :"some-key" => 'value' },
           expected: { someKey: 'value' }
         },
         {
@@ -139,23 +139,23 @@ def test_dash
       scenarios = [
         {
           value: { some_key: 'value' },
-          expected: { "some-key": 'value' }
+          expected: { :"some-key" => 'value' }
         },
         {
           value: { 'some_key' => 'value' },
           expected: { 'some-key' => 'value' }
         },
         {
           value: { SomeKey: 'value' },
-          expected: { "some-key": 'value' }
+          expected: { :"some-key" => 'value' }
         },
         {
           value: { 'SomeKey' => 'value' },
           expected: { 'some-key' => 'value' }
         },
         {
           value: { someKey: 'value' },
-          expected: { "some-key": 'value' }
+          expected: { :"some-key" => 'value' }
         },
         {
           value: { 'someKey' => 'value' },
@@ -200,7 +200,7 @@ def test_underscore
       obj = Object.new
       scenarios = [
         {
-          value: { "some-key": 'value' },
+          value: { :"some-key" => 'value' },
           expected: { some_key: 'value' }
         },
         {
diff --git a/test/adapter/json/transform_test.rb b/test/adapter/json/transform_test.rb
@@ -63,7 +63,7 @@ def test_transform_undefined
         def test_transform_dash
           mock_request(:dash)
           assert_equal({
-                         blog: { id: 1, "special-attribute": 'neat', articles: nil }
+                         blog: { id: 1, :"special-attribute" => 'neat', articles: nil }
                        }, @adapter.serializable_hash)
         end
 
diff --git a/test/adapter/json_api/linked_test.rb b/test/adapter/json_api/linked_test.rb
@@ -370,7 +370,7 @@ def test_no_duplicates_global
           expected = [
             type: 'nested-posts', id: '2',
             relationships: {
-              "nested-posts": {
+              :"nested-posts" => {
                 data: [
                   { type: 'nested-posts', id: '1' },
                   { type: 'nested-posts', id: '2' }
diff --git a/test/adapter/json_api/links_test.rb b/test/adapter/json_api/links_test.rb
@@ -82,10 +82,10 @@ def test_resource_links
               }
             },
             author: 'http://example.com/link_authors/1337',
-            "link-authors": 'http://example.com/link_authors',
+            :"link-authors" => 'http://example.com/link_authors',
             resource: 'http://example.com/resource',
             posts: 'http://example.com/link_authors/1337/posts',
-            "yet-another": 'http://example.com/resource/1337'
+            :"yet-another" => 'http://example.com/resource/1337'
           }
           assert_equal(expected, hash[:data][:links])
         end
diff --git a/test/adapter/json_api/resource_meta_test.rb b/test/adapter/json_api/resource_meta_test.rb
@@ -54,7 +54,7 @@ def test_meta_block_object_resource
               adapter: :json_api
             ).serializable_hash
             expected = {
-              "comments-count": @post.comments.count
+              :"comments-count" => @post.comments.count
             }
             assert_equal(expected, hash[:data][:meta])
           end
@@ -69,8 +69,8 @@ def test_meta_object_resource_in_array
             ).serializable_hash
             expected = {
               data: [
-                { id: '1337', type: 'posts', meta: { "comments-count": 0 } },
-                { id: '1339', type: 'posts', meta: { "comments-count": 1 } }
+                { id: '1337', type: 'posts', meta: { :"comments-count" => 0 } },
+                { id: '1339', type: 'posts', meta: { :"comments-count" => 1 } }
               ]
             }
             assert_equal(expected, hash)
diff --git a/test/adapter/json_api/transform_test.rb b/test/adapter/json_api/transform_test.rb
@@ -76,7 +76,7 @@ def test_success_document_transform_default
                            attributes: {
                              title: 'Title 1',
                              body: 'Body 1',
-                             "publish-at": @publish_at
+                             :"publish-at" => @publish_at
                            },
                            relationships: {
                              author: {
@@ -91,10 +91,10 @@ def test_success_document_transform_default
                            },
                            links: {
                              self: 'http://example.com/posts/1337',
-                             "post-authors": 'http://example.com/posts/1337/authors',
-                             "subscriber-comments": 'http://example.com/posts/1337/comments'
+                             :"post-authors" => 'http://example.com/posts/1337/authors',
+                             :"subscriber-comments" => 'http://example.com/posts/1337/comments'
                            },
-                           meta: { rating: 5, "favorite-count": 10 }
+                           meta: { rating: 5, :"favorite-count" => 10 }
                          }
                        }, result)
         end
@@ -185,7 +185,7 @@ def test_success_document_transform_dash
                            attributes: {
                              title: 'Title 1',
                              body: 'Body 1',
-                             "publish-at": @publish_at
+                             :"publish-at" => @publish_at
                            },
                            relationships: {
                              author: {
@@ -200,10 +200,10 @@ def test_success_document_transform_dash
                            },
                            links: {
                              self: 'http://example.com/posts/1337',
-                             "post-authors": 'http://example.com/posts/1337/authors',
-                             "subscriber-comments": 'http://example.com/posts/1337/comments'
+                             :"post-authors" => 'http://example.com/posts/1337/authors',
+                             :"subscriber-comments" => 'http://example.com/posts/1337/comments'
                            },
-                           meta: { rating: 5, "favorite-count": 10 }
+                           meta: { rating: 5, :"favorite-count" => 10 }
                          }
                        }, result)
         end

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ def test_camel`
`6`	`6`	`obj = Object.new`
`7`	`7`	`scenarios = [`
`8`	`8`	`{`
`9`		`- value: { "some-key": 'value' },`
	`9`	`+ value: { :"some-key" => 'value' },`
`10`	`10`	`expected: { SomeKey: 'value' }`
`11`	`11`	`},`
`12`	`12`	`{`
`@@ -72,7 +72,7 @@ def test_camel_lower`
`72`	`72`	`obj = Object.new`
`73`	`73`	`scenarios = [`
`74`	`74`	`{`
`75`		`- value: { "some-key": 'value' },`
	`75`	`+ value: { :"some-key" => 'value' },`
`76`	`76`	`expected: { someKey: 'value' }`
`77`	`77`	`},`
`78`	`78`	`{`
`@@ -139,23 +139,23 @@ def test_dash`
`139`	`139`	`scenarios = [`
`140`	`140`	`{`
`141`	`141`	`value: { some_key: 'value' },`
`142`		`- expected: { "some-key": 'value' }`
	`142`	`+ expected: { :"some-key" => 'value' }`
`143`	`143`	`},`
`144`	`144`	`{`
`145`	`145`	`value: { 'some_key' => 'value' },`
`146`	`146`	`expected: { 'some-key' => 'value' }`
`147`	`147`	`},`
`148`	`148`	`{`
`149`	`149`	`value: { SomeKey: 'value' },`
`150`		`- expected: { "some-key": 'value' }`
	`150`	`+ expected: { :"some-key" => 'value' }`
`151`	`151`	`},`
`152`	`152`	`{`
`153`	`153`	`value: { 'SomeKey' => 'value' },`
`154`	`154`	`expected: { 'some-key' => 'value' }`
`155`	`155`	`},`
`156`	`156`	`{`
`157`	`157`	`value: { someKey: 'value' },`
`158`		`- expected: { "some-key": 'value' }`
	`158`	`+ expected: { :"some-key" => 'value' }`
`159`	`159`	`},`
`160`	`160`	`{`
`161`	`161`	`value: { 'someKey' => 'value' },`
`@@ -200,7 +200,7 @@ def test_underscore`
`200`	`200`	`obj = Object.new`
`201`	`201`	`scenarios = [`
`202`	`202`	`{`
`203`		`- value: { "some-key": 'value' },`
	`203`	`+ value: { :"some-key" => 'value' },`
`204`	`204`	`expected: { some_key: 'value' }`
`205`	`205`	`},`
`206`	`206`	`{`
Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,10 @@ def test_resource_links`
`82`	`82`	`}`
`83`	`83`	`},`
`84`	`84`	`author: 'http://example.com/link_authors/1337',`
`85`		`- "link-authors": 'http://example.com/link_authors',`
	`85`	`+ :"link-authors" => 'http://example.com/link_authors',`
`86`	`86`	`resource: 'http://example.com/resource',`
`87`	`87`	`posts: 'http://example.com/link_authors/1337/posts',`
`88`		`- "yet-another": 'http://example.com/resource/1337'`
	`88`	`+ :"yet-another" => 'http://example.com/resource/1337'`
`89`	`89`	`}`
`90`	`90`	`assert_equal(expected, hash[:data][:links])`
`91`	`91`	`end`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ def test_meta_block_object_resource`
`54`	`54`	`adapter: :json_api`
`55`	`55`	`).serializable_hash`
`56`	`56`	`expected = {`
`57`		`- "comments-count": @post.comments.count`
	`57`	`+ :"comments-count" => @post.comments.count`
`58`	`58`	`}`
`59`	`59`	`assert_equal(expected, hash[:data][:meta])`
`60`	`60`	`end`
`@@ -69,8 +69,8 @@ def test_meta_object_resource_in_array`
`69`	`69`	`).serializable_hash`
`70`	`70`	`expected = {`
`71`	`71`	`data: [`
`72`		`- { id: '1337', type: 'posts', meta: { "comments-count": 0 } },`
`73`		`- { id: '1339', type: 'posts', meta: { "comments-count": 1 } }`
	`72`	`+ { id: '1337', type: 'posts', meta: { :"comments-count" => 0 } },`
	`73`	`+ { id: '1339', type: 'posts', meta: { :"comments-count" => 1 } }`
`74`	`74`	`]`
`75`	`75`	`}`
`76`	`76`	`assert_equal(expected, hash)`