You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- What are you using ActiveModelSerializers with? Rails? Grape? Other? Which versions?
31
31
- If you are not running the latest version (please check), and you cannot update it,
32
32
please specify in your report why you can't update to the latest version.
33
-
- Operating system type + version
34
-
- Ruby version with patch level. And if you're using rvm, rbenv, etc.
33
+
- Operating system type + version.
34
+
- Ruby version with patch level. And whether you're using rvm, rbenv, etc.
35
35
- Include your ruby -e "puts RUBY_DESCRIPTION".
36
36
- Clearly-written steps to reproduce the issue (i.e. "Show me how to show myself." ), including:
37
37
- What were you doing? Include code if possible.
38
38
- Command line parameters used, if any.
39
-
- RubyGems code in your Gemfile, if any. Gemfile.lock, if possible
40
-
- Any configuration you've made
39
+
- RubyGems code in your Gemfile, if any. Gemfile.lock, if possible.
40
+
- Any configuration you've made.
41
41
- What did you expect to happen?
42
42
- What happened? Include as much information as possible.
43
43
- Nature of reported defect (e.g. user name missing, not "It doesn't work."). Is it intermittent?
44
-
- The best help here is a failing test.
44
+
- The best help here is a failing test. Even better if it's a PR.
45
45
- Then the steps to reproduce and/or a gist or repository that demonstrates the defect.
46
46
- Then examples of the code you were using.
47
47
- Any error messages (including stacktrace, i.e. ""Show me the error.")
48
48
- Things you've tried.
49
49
- A pull request for your fix would be great. Code should have tests.
50
-
- Link to source code, if available
50
+
- Link to source code, if available.
51
51
52
52
Please make sure only to include one issue per report.
53
53
If you encounter multiple, unrelated issues, please report them as such.
@@ -79,7 +79,7 @@ what you've found is *extremely* helpful.
79
79
80
80
If you solve your issue, stop working on it, or realize the problem was something else,
81
81
please share that in a comment to an issue and close it. That way, everyone can learn and
82
-
we don't have closing issues without a clear resolution. Even if it's just a stackoverflow link :)
82
+
we don't have closed issues without a clear resolution. Even if it's just a stackoverflow link :)
83
83
And please don't forget to stay involved in the issue until it is closed! Thanks to all!
84
84
85
85
### Writing code and comments
@@ -103,9 +103,9 @@ ActiveModelSerializers uses a subset of [StandardIssueLabels](https://github.com
103
103
104
104
## Submitting a pull request (PR)
105
105
106
-
1. The vast majority of development is happening under the `master` branch, currently slated for release as `0.10.x`.
106
+
1. The vast majority of development is happening under the `master` branch.
107
107
This is where we would suggest you start.
108
-
1. Fixing bugs is extraordinarily helpful and requires the least familiarity with ActiveModelSerializer.
108
+
1. Fixing bugs is extraordinarily helpful and requires the least familiarity with ActiveModelSerializers.
109
109
Look for issues labeled [**Needs Bug Verification**](https://github.com/rails-api/active_model_serializers/labels/Needs%20Bug%20Verification) and [**Bug**](https://github.com/rails-api/active_model_serializers/labels/bug).
110
110
1. Adding or fixing documentation is also fantastic!
111
111
@@ -120,7 +120,7 @@ To fetch & test the library for development, do:
120
120
e.g. `export RAILS_VERSION=4.0`.
121
121
1. Create your PR branch (`git checkout -b my-helpful-pr`)
122
122
1. Write tests for your feature, or regression tests highlighting a bug.
123
-
This is important so AcitveModel Serializers doesn't break it in a future version unintentionally.
123
+
This is important so ActiveModelSerializers doesn't break it in a future version unintentionally.
124
124
1. Write the feature itself, or fix your bug
125
125
1.`bundle exec rake`
126
126
1. Commit your changes (`git commit -am 'Add some feature'`)
@@ -138,7 +138,7 @@ To fetch & test the library for development, do:
138
138
1. Iterate on feedback given by the community (fix syntax, modify bits of code, add
139
139
tests), pushing the new commits to the PR each time
140
140
141
-
Remember to [squash your commits] and rebase off `master`.
141
+
Remember to [squash your commits](CONTRIBUTING.md#about-pull-requests-prs) and rebase off `master`.
_Windows Build Status -_[](https://ci.appveyor.com/project/joaomdmoura/active-model-serializers/branch/master)
8
8
9
-
ActiveModel::Serializer brings convention over configuration to your JSON generation.
9
+
ActiveModelSerializers brings convention over configuration to your JSON generation.
10
10
11
11
AMS does this through two components: **serializers** and **adapters**.
12
12
Serializers describe _which_ attributes and relationships should be serialized.
0 commit comments