Refactor TestUser in SerializationScopeNameTest

Use the same base class we use for other test models

Author: mateomurphy

test/action_controller/serialization_scope_name_test.rb

@@ -2,8 +2,6 @@
 require 'pathname'
 
 class DefaultScopeNameTest < ActionController::TestCase
-  TestUser = Struct.new(:id, :name, :admin)
-
   class UserSerializer < ActiveModel::Serializer
     attributes :admin?
     def admin?
@@ -17,25 +15,23 @@ class UserTestController < ActionController::Base
     before_filter { request.format = :json }
 
     def current_user
-      TestUser.new(1, 'Pete', false)
+      User.new(id: 1, name: 'Pete', admin: false)
     end
 
     def render_new_user
-      render json: TestUser.new(1, 'pete', false), serializer: UserSerializer, adapter: :json_api
+      render json: User.new(id: 1, name: 'Pete', admin: false), serializer: UserSerializer, adapter: :json_api
     end
   end
 
  tests UserTestController
 
   def test_default_scope_name
     get :render_new_user
-    assert_equal '{"data":{"admin?":false,"id":"1","type":"test_users"}}', @response.body
+    assert_equal '{"data":{"admin?":false,"id":"1","type":"users"}}', @response.body
   end
 end
 
 class SerializationScopeNameTest < ActionController::TestCase
-  TestUser = Struct.new(:id, :name, :admin)
-
   class AdminUserSerializer < ActiveModel::Serializer
     attributes :admin?
     def admin?
@@ -50,18 +46,18 @@ class AdminUserTestController < ActionController::Base
     before_filter { request.format = :json }
 
     def current_admin
-      TestUser.new(1, 'Bob', true)
+      User.new(id: 2, name: 'Bob', admin: true)
     end
 
     def render_new_user
-      render json: TestUser.new(1, 'pete', false), serializer: AdminUserSerializer, adapter: :json_api
+      render json: User.new(id: 1, name: 'Pete', admin: false), serializer: AdminUserSerializer, adapter: :json_api
     end
   end
 
   tests AdminUserTestController
 
   def test_override_scope_name_with_controller
     get :render_new_user
-    assert_equal '{"data":{"admin?":true,"id":"1","type":"test_users"}}', @response.body
+    assert_equal '{"data":{"admin?":true,"id":"1","type":"users"}}', @response.body
   end
 end

test/fixtures/poro.rb

@@ -63,6 +63,7 @@ class ProfilePreviewSerializer < ActiveModel::Serializer
 Bio = Class.new(Model)
 Blog = Class.new(Model)
 Role = Class.new(Model)
+User = Class.new(Model)
 module Spam; end
 Spam::UnrelatedLink = Class.new(Model)