|
| 1 | +- Start Date: (2015-10-29) |
| 2 | +- RFC PR: (leave this empty) |
| 3 | +- AMS Issue: (leave this empty) |
| 4 | + |
| 5 | +# Summary |
| 6 | + |
| 7 | +Provide a consistent API for the user of the AMS. |
| 8 | + |
| 9 | +# Motivation |
| 10 | + |
| 11 | +The actual public API is defined under `ActiveModelSerializers`, |
| 12 | +`ActiveModel::Serializer` and `ActiveModel`. |
| 13 | + |
| 14 | +At the `ActiveModel::Serializer` we have: |
| 15 | + |
| 16 | +- `ActiveModel::Serializer.config` |
| 17 | +- `ActiveModel::Serializer` |
| 18 | + |
| 19 | +At the `ActiveModelSerializers` we have: |
| 20 | + |
| 21 | +- `ActiveModelSerializers::Model` |
| 22 | +- `ActiveModelSerializers.logger` |
| 23 | + |
| 24 | +At `ActiveModel` we have: |
| 25 | + |
| 26 | +- `ActiveModel::SerializableResource` |
| 27 | + |
| 28 | +The idea here is to provide a single namespace `ActiveModel::Serializers` to the user. |
| 29 | +Following the same idea we have on other gems like |
| 30 | +[Devise](https://github.com/plataformatec/devise/blob/e9c82472ffe7c43a448945f77e034a0e47dde0bb/lib/devise.rb), |
| 31 | +[Refile](https://github.com/refile/refile/blob/6b24c293d044862dafbf1bfa4606672a64903aa2/lib/refile.rb) and |
| 32 | +[Active Job](https://github.com/rails/rails/blob/30bacc26f8f258b39e12f63fe52389a968d9c1ea/activejob/lib/active_job.rb) |
| 33 | +for example. |
| 34 | + |
| 35 | +# Detailed design |
| 36 | + |
| 37 | +## Require statement and main module |
| 38 | + |
| 39 | +We are adding a extension for the Active Model, so |
| 40 | +[following the Rubygens recomendation](http://guides.rubygems.org/name-your-gem/) |
| 41 | +for the gem name we need to change to this. |
| 42 | + |
| 43 | +|Gem name | Require statement | Main class or module | |
| 44 | +|--------------------------|----------------------------|--------------------------| |
| 45 | +| active_model_serializers | `active_model/serializers` | ActiveModel::Serializers | |
| 46 | + |
| 47 | +The expected gem name, in the gemspec is `active_model-serializers` but we don't |
| 48 | +need to change this, we can change the code without the need of a new gem on Rubygems. |
| 49 | + |
| 50 | +Active Model for example follow the same idea the gem name on gemspec is `activemodel` and to the end user is: |
| 51 | + |
| 52 | +|Gem name | Require statement | Main class or module | |
| 53 | +|--------------------------|----------------------------|--------------------------| |
| 54 | +| activemodel | `active_model` | ActiveModel | |
| 55 | + |
| 56 | +As you can see we do not require `activemodel`(the gem name in gemspec) insted |
| 57 | +we use `active_model`. |
| 58 | + |
| 59 | +And based on the [bump of `0.10.0.pre` released by Steve Klabnik](https://github.com/rails-api/active_model_serializers/tree/86fc7d7227f3ce538fcb28c1e8c7069ce311f0e1) |
| 60 | +if we take a look on README and gemspec always is used `ActiveModel::Serializers`. |
| 61 | + |
| 62 | +## New classes and modules organization |
| 63 | + |
| 64 | +Since this will be a big change we can do this on baby steps, read small PRs. A |
| 65 | +possible approach is: |
| 66 | + |
| 67 | +- Create the `ActiveModel::Serializers` namespace; |
| 68 | +- Move all content under `ActiveModelSerializers` to be under |
| 69 | + `ActiveModel::Serializers`, the logger is on this step; |
| 70 | +- Move all content under `ActiveModel::Serializer` to be under |
| 71 | + `ActiveModel::Serializers`, the adapter is on this steps; |
| 72 | +- Move all content under `ActiveModel` to be under `ActiveModel::Serializers`, |
| 73 | + the `SerializableResource` is on this step; |
| 74 | +- Now that all the code lives under `ActiveModel::Serializers` we can: |
| 75 | + - create a better name to the `ActiveModel::Serializers::Serializer` |
| 76 | + keeping in mind only to keep this in the same namespace |
| 77 | + - create a better name to the `ActiveModel::Serializers::Serializer::Adapter::JsonApi` |
| 78 | + probably remove this from the `ActiveModel::Serializers::Serializer` |
| 79 | + and do something like `ActiveModel::Serializers::Adapter::JsonApi` |
| 80 | + keeping in mind only to keep this in the same namespace |
| 81 | + - Change all public API that doesn't make sense, keeping in mind only to keep |
| 82 | + this in the same namespace |
| 83 | +- Update the README; |
| 84 | +- Update the docs; |
| 85 | + |
| 86 | +The following table represents the current and the desired classes and modules |
| 87 | +at the first moment. |
| 88 | + |
| 89 | +| Current | Desired | Notes | |
| 90 | +|-------------------------------------------------------|--------------------------------------------------|--------------------| |
| 91 | +|`ActiveModelSerializers` and `ActiveModel::Serializer` | `ActiveModel::Serializers` | The main namespace | |
| 92 | +| `ActiveModelSerializers.logger` | `ActiveModel::Serializers.logger` || |
| 93 | +|`ActiveModelSerializers::Model` | `ActiveModel::Serializers::Model` || |
| 94 | +|`ActiveModel::SerializableResource` | `ActiveModel::Serializers::SerializableResource` || |
| 95 | +| `ActiveModel::Serializer` | `ActiveModel::Serializers::Serializer` | I know that is probably a bad name, but In a second moment we can rename this to `Resource` [for example following this idea](https://github.com/rails-api/active_model_serializers/pull/1301/files#r42963185)| |
| 96 | +|`ActiveModel::Serializer.config` | `ActiveModel::Serializers.config` || |
| 97 | + |
| 98 | +# Drawbacks |
| 99 | + |
| 100 | +This will be a breaking change, so all users serializers will be broken. |
| 101 | +All PRs will need to rebase since the architeture will change a lot. |
| 102 | + |
| 103 | +# Alternatives |
| 104 | + |
| 105 | +We can keep the way it is, and keep in mind to not add another namespace as a |
| 106 | +public API. |
| 107 | + |
| 108 | +Or we can start moving the small ones that seems to be the |
| 109 | +`ActiveModelSerializers` and `ActiveModel` and later we can handle the |
| 110 | +`ActiveModel::Serializer`. |
| 111 | + |
| 112 | +# Unresolved questions |
| 113 | + |
| 114 | +What is the better class name to be used to the class that will be inherited at |
| 115 | +the creation of a serializer. |
0 commit comments