Skip to content

Commit a39d08d

Browse files
committed
Cleaner unsuffixed association keys tests
1 parent 226cbc4 commit a39d08d

File tree

3 files changed

+22
-16
lines changed

3 files changed

+22
-16
lines changed

test/fixtures/poro.rb

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,3 +142,25 @@ module TestNamespace
142142
class ProfileSerializer < ::ProfileSerializer; end
143143
class UserSerializer < ::UserSerializer; end
144144
end
145+
146+
ActiveModel::Serializer.setup do |config|
147+
config.default_key_type = :name
148+
end
149+
150+
class NameKeyUserSerializer < ActiveModel::Serializer
151+
attributes :name, :email
152+
153+
has_one :profile
154+
end
155+
156+
class NameKeyPostSerializer < ActiveModel::Serializer
157+
attributes :title, :body
158+
159+
has_many :comments
160+
end
161+
162+
ActiveModel::Serializer.setup do |config|
163+
config.default_key_type = nil
164+
end
165+
166+

test/unit/active_model/serializer/has_many_test.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -243,14 +243,6 @@ def test_associations_embedding_objects_using_embed_namespace
243243
}, @post_serializer.as_json)
244244
end
245245

246-
CONFIG.default_key_type = :name
247-
class NameKeyPostSerializer < ActiveModel::Serializer
248-
attributes :title, :body
249-
250-
has_many :comments
251-
end
252-
CONFIG.default_key_type = nil
253-
254246
def test_associations_name_key_embedding_ids_serialization_using_serializable_hash
255247
@association = NameKeyPostSerializer._associations[:comments]
256248
@association.embed = :ids

test/unit/active_model/serializer/has_one_test.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -217,14 +217,6 @@ def test_associations_embedding_ids_using_embed_namespace_and_embed_in_root_key
217217
}, @user_serializer.as_json)
218218
end
219219

220-
CONFIG.default_key_type = :name
221-
class NameKeyUserSerializer < ActiveModel::Serializer
222-
attributes :name, :email
223-
224-
has_one :profile
225-
end
226-
CONFIG.default_key_type = nil
227-
228220
def test_associations_name_key_embedding_ids_serialization_using_serializable_hash
229221
@association = NameKeyUserSerializer._associations[:profile]
230222
@association.embed = :ids

0 commit comments

Comments
 (0)