Allow Redis to config host url.

Author: huacnlee

CHANGELOG.md

@@ -1,3 +1,8 @@
+0.1.4
+
+- Allow Redis to config host url.
+- Update service options API in configure.
+
 0.1.3
 -----
 

README.md

@@ -52,6 +52,8 @@ StatusPage.configure do
   self.use :database
   self.use :cache
   self.use :redis
+  # Custom redis url
+  self.use :redis, url: 'redis://you-redis-host:3306/1'
   self.use :sidekiq
 end
 ```

lib/status-page/configuration.rb

@@ -8,9 +8,15 @@ def initialize
       @interval = 10
     end
 
-    def use(service_name)
+    def use(service_name, opts = {})
       require "status-page/services/#{service_name}"
-      add_service("StatusPage::Services::#{service_name.capitalize}".constantize)
+      klass = "StatusPage::Services::#{service_name.capitalize}".constantize
+      if klass.respond_to?(:configurable?) && klass.configurable?
+        opts.each_key do |key|
+          klass.config.send("#{key}=", opts[key])
+        end
+      end
+      add_service(klass)
     end
 
     def add_custom_service(custom_service_class)

lib/status-page/services/base.rb

@@ -2,31 +2,29 @@ module StatusPage
   module Services
     class Base
       attr_reader :request
-      cattr_accessor :config
-
-      def self.service_name
-        @name ||= name.demodulize
-      end
-
-      def self.configure
-        return unless configurable?
-
-        self.config ||= config_class.new
-
-        yield self.config if block_given?
-      end
 
       def initialize(request: nil)
         @request = request
+      end
 
-        self.class.configure
+      def self.service_name
+        @name ||= name.demodulize
       end
 
       # @abstract
       def check!
         raise NotImplementedError
       end
 
+      def self.config
+        return nil if !self.configurable?
+        @config ||= config_class.new
+      end
+
+      def config
+        self.class.config
+      end
+
       def self.configurable?
         config_class
       end

lib/status-page/services/redis.rb

@@ -5,18 +5,32 @@ module Services
     class RedisException < StandardError; end
 
     class Redis < Base
+      class Configuration
+        attr_accessor :url
+
+        def initialize
+          @url = "redis://127.0.0.1:3306/1"
+        end
+      end
+
+      class << self
+        def config_class
+          Redis::Configuration
+        end
+      end
+
       def check!
         time = Time.now.to_s(:db)
 
-        redis = ::Redis.current
+        redis = ::Redis.new(url: config.url)
         redis.set(key, time)
         fetched = redis.get(key)
 
         raise "different values (now: #{time}, fetched: #{fetched})" if fetched != time
       rescue Exception => e
         raise RedisException.new(e.message)
       ensure
-        redis.client.disconnect
+        redis.disconnect
       end
 
       private

lib/status-page/services/sidekiq.rb

@@ -29,7 +29,7 @@ class << self
         private
 
         def config_class
-          Configuration
+          Sidekiq::Configuration
         end
       end
 
@@ -44,7 +44,6 @@ def check_latency!
         latency = ::Sidekiq::Queue.new.latency
 
         return unless latency > config.latency
-
         raise "latency #{latency} is greater than #{config.latency}"
       end
 

spec/lib/status-page/configuration_spec.rb

@@ -27,6 +27,13 @@
     end
   end
 
+  describe 'use with opts' do
+    it 'should use redis with opts' do
+      subject.use(:redis, url: 'redis://asdgas:3380')
+      expect(StatusPage::Services::Redis.config.url).to eq 'redis://asdgas:3380'
+    end
+  end
+
   describe '#add_custom_service' do
     before do
       subject.instance_variable_set('@providers', Set.new)

spec/lib/status-page/services/redis_spec.rb

@@ -28,7 +28,7 @@
   end
 
   describe '#configurable?' do
-    it { expect(described_class).not_to be_configurable }
+    it { expect(described_class).to be_configurable }
   end
 
   describe '#key' do

spec/lib/status-page/services/sidekiq_spec.rb

@@ -3,7 +3,7 @@
 describe StatusPage::Services::Sidekiq do
   describe StatusPage::Services::Sidekiq::Configuration do
     describe 'defaults' do
-      it { expect(described_class.new.latency).to eq(StatusPage::Services::Sidekiq::Configuration::DEFAULT_LATENCY_TIMEOUT) }
+      it { expect(described_class.new.latency).to eq(30) }
     end
   end
 
@@ -77,9 +77,7 @@
       latency = 123
 
       expect {
-        described_class.configure do |config|
-          config.latency = latency
-        end
+        described_class.config.latency = latency
       }.to change { described_class.config.latency }.to(latency)
     end
   end