Update factories (#1039)

This updates the season and project factories to prevent name-collisions
(and the risk of flaky specs).

Author: klappradla

spec/factories/projects.rb

@@ -30,9 +30,5 @@
     trait :in_current_season do
       season { Season.current }
     end
-
-    trait :in_last_season do
-      season { Season.find_or_create_by name: (Date.today.year - 1) }
-    end
   end
 end

spec/factories/season.rb

@@ -4,6 +4,6 @@
   end
 
   trait :past do
-    name '2010'
+    name '1999'
   end
 end

spec/models/project_spec.rb

@@ -23,26 +23,26 @@
       subject(:selected) { described_class.selected }
 
       let!(:current_season) { Season.current }
-      let!(:other_season)   { create(:season) }
+      let!(:past_season)    { create(:season, :past) }
 
       let!(:project1) { create(:project, season: current_season) }
       let!(:project2) { create(:project, :accepted, season: current_season) }
       let!(:project3) { create(:project, :accepted, season: current_season) }
       let!(:project4) { create(:project, :accepted, season: current_season) }
-      let!(:project5) { create(:project, :accepted, season: other_season) }
+      let!(:project5) { create(:project, :accepted, season: past_season) }
 
       before do
         create(:team, kind: 'full_time', project: project3, season: current_season)
         create(:team, kind: nil, project: project4, season: current_season)
-        create(:team, kind: 'full_time', project: project5, season: other_season)
+        create(:team, kind: 'full_time', project: project5, season: past_season)
       end
 
       it 'returns only accepted projects with accepted teams' do
         expect(selected).to contain_exactly(project3)
       end
 
       context 'when passing a specific season' do
-        subject(:selected) { described_class.selected(season: other_season) }
+        subject(:selected) { described_class.selected(season: past_season) }
 
         it 'returns only accepted projects with accepted teams from that season' do
           expect(selected).to contain_exactly(project5)