Add rubocop and fix offenses

Author: pixeltrix

.codeclimate.yml

@@ -0,0 +1,7 @@
+engines:
+  rubocop:
+    enabled: true
+
+ratings:
+  paths:
+  - "**.rb"

.rubocop.yml

@@ -0,0 +1,116 @@
+AllCops:
+  TargetRubyVersion: 2.2
+  # RuboCop has a bunch of cops enabled by default. This setting tells RuboCop
+  # to ignore them, so only the ones explicitly set in this file are enabled.
+  DisabledByDefault: true
+
+# Prefer &&/|| over and/or.
+Style/AndOr:
+  Enabled: true
+
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
+  Enabled: true
+
+# Align `when` with `case`.
+Style/CaseIndentation:
+  Enabled: true
+
+# Align comments with method definitions.
+Style/CommentIndentation:
+  Enabled: true
+
+# No extra empty lines.
+Style/EmptyLines:
+  Enabled: true
+
+# In a regular class definition, no empty lines around the body.
+Style/EmptyLinesAroundClassBody:
+  Enabled: true
+
+# In a regular module definition, no empty lines around the body.
+Style/EmptyLinesAroundModuleBody:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Method definitions after `private` or `protected` isolated calls need one
+# extra level of indentation.
+Style/IndentationConsistency:
+  Enabled: true
+  EnforcedStyle: rails
+
+# Two spaces, no tabs (for indentation).
+Style/IndentationWidth:
+  Enabled: true
+
+Style/SpaceAfterColon:
+  Enabled: true
+
+Style/SpaceAfterComma:
+  Enabled: true
+
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Style/SpaceAroundKeyword:
+  Enabled: true
+
+Style/SpaceAroundOperators:
+  Enabled: true
+
+Style/SpaceBeforeFirstArg:
+    Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Style/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Style/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Style/SpaceInsideParens:
+  Enabled: true
+
+# Check quotes usage according to lint rule below.
+Style/StringLiterals:
+  Enabled: true
+  EnforcedStyle: double_quotes
+
+# Detect hard tabs, no hard tabs.
+Style/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Style/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Style/TrailingWhitespace:
+  Enabled: true
+
+# Use quotes for string literals when they are enough.
+Style/UnneededPercentQ:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Lint/EndAlignment:
+  Enabled: true
+  AlignWith: variable
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true

Gemfile

@@ -1,5 +1,5 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 gemspec
 
-gem 'rails'
+gem "rails"

README.md

@@ -8,7 +8,7 @@ Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'actionpack-action_caching'
+    gem "actionpack-action_caching"
 
 And then execute:
 
@@ -54,8 +54,8 @@ Different representations of the same resource, e.g.
 `http://david.example.com/lists.xml`
 are treated like separate requests and so are cached separately.
 Keep in mind when expiring an action cache that
-`action: 'lists'` is not the same as
-`action: 'list', format: :xml`.
+`action: "lists"` is not the same as
+`action: "list", format: :xml`.
 
 You can modify the default action cache path by passing a
 `:cache_path` option. This will be passed directly to

Rakefile

@@ -1,11 +1,11 @@
 #!/usr/bin/env rake
-require 'bundler/gem_tasks'
-require 'rake/testtask'
+require "bundler/gem_tasks"
+require "rake/testtask"
 
 Rake::TestTask.new do |t|
-  t.libs = ['test']
-  t.pattern = 'test/**/*_test.rb'
-  t.ruby_opts = ['-w']
+  t.libs = ["test"]
+  t.pattern = "test/**/*_test.rb"
+  t.ruby_opts = ["-w"]
 end
 
 task default: :test

actionpack-action_caching.gemspec

@@ -1,18 +1,18 @@
 Gem::Specification.new do |gem|
-  gem.name          = 'actionpack-action_caching'
-  gem.version       = '1.1.1'
-  gem.author        = 'David Heinemeier Hansson'
-  gem.email         = '[email protected]'
-  gem.description   = 'Action caching for Action Pack (removed from core in Rails 4.0)'
-  gem.summary       = 'Action caching for Action Pack (removed from core in Rails 4.0)'
-  gem.homepage      = 'https://github.com/rails/actionpack-action_caching'
+  gem.name          = "actionpack-action_caching"
+  gem.version       = "1.1.1"
+  gem.author        = "David Heinemeier Hansson"
+  gem.email         = "[email protected]"
+  gem.description   = "Action caching for Action Pack (removed from core in Rails 4.0)"
+  gem.summary       = "Action caching for Action Pack (removed from core in Rails 4.0)"
+  gem.homepage      = "https://github.com/rails/actionpack-action_caching"
 
-  gem.required_ruby_version = '>= 1.9.3'
+  gem.required_ruby_version = ">= 1.9.3"
   gem.files         = `git ls-files`.split($/)
-  gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
+  gem.executables   = gem.files.grep(%r{^bin/}).map { |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
-  gem.require_paths = ['lib']
-  gem.license       = 'MIT'
+  gem.require_paths = ["lib"]
+  gem.license       = "MIT"
 
   gem.add_dependency "actionpack", ">= 4.0.0", "< 6"
 

lib/action_controller/action_caching.rb

@@ -1,4 +1,4 @@
-require 'action_controller/caching/actions'
+require "action_controller/caching/actions"
 
 module ActionController
   module Caching

lib/action_controller/caching/actions.rb

@@ -1,4 +1,4 @@
-require 'set'
+require "set"
 
 module ActionController
   module Caching
@@ -35,8 +35,8 @@ module Caching
     # <tt>http://david.example.com/lists.xml</tt>
     # are treated like separate requests and so are cached separately.
     # Keep in mind when expiring an action cache that
-    # <tt>action: 'lists'</tt> is not the same as
-    # <tt>action: 'lists', format: :xml</tt>.
+    # <tt>action: "lists"</tt> is not the same as
+    # <tt>action: "lists", format: :xml</tt>.
     #
     # You can modify the default action cache path by passing a
     # <tt>:cache_path</tt> option. This will be passed directly to
@@ -85,7 +85,7 @@ module Caching
     #       end
     #     end
     #
-    #     caches_action :posts, cache_path: CachePathCreator.new('posts')
+    #     caches_action :posts, cache_path: CachePathCreator.new("posts")
     #   end
     #
     # If you pass <tt>layout: false</tt>, it will only cache your action
@@ -118,7 +118,7 @@ def caches_action(*actions)
       end
 
       def _save_fragment(name, options)
-        content = ''
+        content = ""
         response_body.each do |parts|
           content << parts
         end
@@ -179,7 +179,7 @@ def around(controller)
           controller.content_type = Mime[cache_path.extension || :html]
         end
 
-        if ActionPack::VERSION::STRING < '4.1'
+        if ActionPack::VERSION::STRING < "4.1"
           def render_to_string(controller, body)
             controller.render_to_string(text: body, layout: true)
           end
@@ -203,15 +203,15 @@ def initialize(controller, options = {}, infer_extension = true)
             options.reverse_merge!(format: @extension) if options.is_a?(Hash)
           end
 
-          path = controller.url_for(options).split('://', 2).last
+          path = controller.url_for(options).split("://", 2).last
           @path = normalize!(path)
         end
 
       private
         def normalize!(path)
           ext = URI.parser.escape(extension.to_s) if extension
-          path << 'index' if path[-1] == ?/
-          path << ".#{ext}" if extension and !path.split('?', 2).first.ends_with?(".#{ext}")
+          path << "index" if path[-1] == ?/
+          path << ".#{ext}" if extension && !path.split("?", 2).first.ends_with?(".#{ext}")
           URI.parser.unescape(path)
         end
       end

lib/actionpack/action_caching.rb

@@ -1 +1 @@
-require 'actionpack/action_caching/railtie'
+require "actionpack/action_caching/railtie"

lib/actionpack/action_caching/railtie.rb

@@ -1,11 +1,11 @@
-require 'rails/railtie'
+require "rails/railtie"
 
 module ActionPack
   module ActionCaching
     class Railtie < Rails::Railtie
-      initializer 'action_pack.action_caching' do
+      initializer "action_pack.action_caching" do
         ActiveSupport.on_load(:action_controller) do
-          require 'action_controller/action_caching'
+          require "action_controller/action_caching"
         end
       end
     end