Skip to content

Commit d70e3c1

Browse files
committed
Move features to the new organization
See https://github.com/devcontainers/feature-starter/tree/67a45f05bb47843fef96f53ab09eab04680f6d95 This will allow us to write tests for the features.
1 parent f3bb12d commit d70e3c1

24 files changed

+22
-6
lines changed

.devcontainer/devcontainer.json

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
{
44
"name": "Docker in Docker",
55
// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
6-
"image": "mcr.microsoft.com/devcontainers/javascript-node:0-18",
6+
"image": "mcr.microsoft.com/devcontainers/javascript-node:1-20-bookworm",
77

88
"features": {
99
"ghcr.io/devcontainers/features/docker-in-docker:2": {
@@ -17,11 +17,27 @@
1717
// "forwardPorts": [],
1818

1919
// Use 'postCreateCommand' to run commands after the container is created.
20-
"postCreateCommand": "npm install -g @devcontainers/cli"
20+
"postCreateCommand": "npm install -g @devcontainers/cli",
2121

2222
// Configure tool-specific properties.
23-
// "customizations": {},
23+
"customizations": {
24+
"vscode": {
25+
"settings": {
26+
"json.schemas": [
27+
{
28+
"fileMatch": [
29+
"*/devcontainer-feature.json"
30+
],
31+
"url": "https://raw.githubusercontent.com/devcontainers/spec/main/schemas/devContainerFeature.schema.json"
32+
}
33+
]
34+
},
35+
"extensions": [
36+
"mads-hartmann.bash-ide-vscode"
37+
]
38+
}
39+
},
2440

2541
// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
26-
// "remoteUser": "root"
42+
"remoteUser": "node",
2743
}

.github/.devcontainer/features

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
../../features
1+
../../features/src

.github/workflows/release-features.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
uses: devcontainers/action@v1
1919
with:
2020
publish-features: "true"
21-
base-path-to-features: "./features"
21+
base-path-to-features: "./features/src"
2222
features-namespace: "rails/devcontainer/features"
2323
env:
2424
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)