Packager should be able to remove packages from importmap itself

Author: David Heinemeier Hansson

lib/importmap/commands.rb

@@ -41,12 +41,11 @@ def unpin(*packages)
         if packager.packaged?(package)
           if options[:download]
             puts %(Unpinning and removing "#{package}")
-            packager.remove(package)
           else
             puts %(Unpinning "#{package}")
           end
 
-          remove_line_from_file "config/importmap.rb", /pin "#{package}"/
+          packager.remove(package)
         end
       end
     else

lib/importmap/packager.rb

@@ -53,6 +53,7 @@ def download(package, url)
 
   def remove(package)
     remove_existing_package_file(package)
+    remove_package_from_importmap(package)
   end
 
   private
@@ -94,6 +95,15 @@ def remove_existing_package_file(package)
       FileUtils.rm_rf "#{vendored_package_path(package)}.br" # Temp workaround for jspm.io
     end
 
+    def remove_package_from_importmap(package)
+      all_lines = File.readlines(@importmap_path)
+      with_lines_removed = all_lines.select { |line| line !~ /pin "#{package}"/ }
+
+      File.open(@importmap_path, "w") do |file|
+        with_lines_removed.each { |line| file.write(line) }
+      end
+    end
+
     def download_package_file(package, url)
       if url =~ /jspm.io/
         # Temporary workaround jspm.io only sending brotli