Fix generation of broken controller on Rails 5.0 when ran w/o fields

Author: diego-silva

lib/generators/rails/templates/api_controller.rb

@@ -54,7 +54,7 @@ def set_<%= singular_table_name %>
     # Never trust parameters from the scary internet, only allow the white list through.
     def <%= "#{singular_table_name}_params" %>
       <%- if attributes_names.empty? -%>
-      params[<%= ":#{singular_table_name}" %>]
+      params.fetch(<%= ":#{singular_table_name}" %>, {})
       <%- else -%>
       params.require(<%= ":#{singular_table_name}" %>).permit(<%= attributes_names.map { |name| ":#{name}" }.join(', ') %>)
       <%- end -%>

lib/generators/rails/templates/controller.rb

@@ -75,7 +75,7 @@ def set_<%= singular_table_name %>
     # Never trust parameters from the scary internet, only allow the white list through.
     def <%= "#{singular_table_name}_params" %>
       <%- if attributes_names.empty? -%>
-      params[<%= ":#{singular_table_name}" %>]
+      params.fetch(<%= ":#{singular_table_name}" %>, {})
       <%- else -%>
       params.require(<%= ":#{singular_table_name}" %>).permit(<%= attributes_names.map { |name| ":#{name}" }.join(', ') %>)
       <%- end -%>

test/scaffold_api_controller_generator_test.rb

@@ -42,5 +42,14 @@ class ScaffoldApiControllerGeneratorTest < Rails::Generators::TestCase
         assert_match(/params\.require\(:post\)\.permit\(:title, :body\)/, content)
       end
     end
+
+    test 'dont use require and permit if there are no attributes' do
+      run_generator %w(Post --api)
+
+      assert_file 'app/controllers/posts_controller.rb' do |content|
+        assert_match(/def post_params/, content)
+        assert_match(/params\.fetch\(:post, {}\)/, content)
+      end
+    end
   end
 end

test/scaffold_controller_generator_test.rb

@@ -54,4 +54,13 @@ class ScaffoldControllerGeneratorTest < Rails::Generators::TestCase
       assert_match(/params\.require\(:post\)\.permit\(:title, :body\)/, content)
     end
   end
+
+  test 'dont use require and permit if there are no attributes' do
+    run_generator %w(Post)
+
+    assert_file 'app/controllers/posts_controller.rb' do |content|
+      assert_match(/def post_params/, content)
+      assert_match(/params\.fetch\(:post, {}\)/, content)
+    end
+  end
 end