Skip to content

Commit 3536726

Browse files
committed
Merge pull request #292 from maclover7/contributing
Add CONTRIBUTING.md
2 parents 0102fb3 + f060fd5 commit 3536726

File tree

3 files changed

+113
-11
lines changed

3 files changed

+113
-11
lines changed

CONTRIBUTING.md

Lines changed: 102 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,102 @@
1+
Contributing to Jbuilder
2+
=====================
3+
4+
[![Build Status](https://travis-ci.org/rails/jbuilder.svg?branch=master)]()
5+
[![Gem Version](http://img.shields.io/gem/v/jbuilder.svg)]()
6+
[![Code Climate](http://img.shields.io/codeclimate/github/rails/jbuilder.svg)]()
7+
[![Dependencies Status](http://img.shields.io/gemnasium/rails/jbuilder.svg)]()
8+
9+
Jbuilder is work of [many contributors](https://github.com/rails/jbuilder/graphs/contributors). You're encouraged to submit [pull requests](https://github.com/rails/jbuilder/pulls), [propose features and discuss issues](https://github.com/rails/jbuilder/issues).
10+
11+
#### Fork the Project
12+
13+
Fork the [project on Github](https://github.com/rails/jbuilder) and check out your copy.
14+
15+
```
16+
git clone https://github.com/contributor/jbuilder.git
17+
cd jbuilder
18+
git remote add upstream https://github.com/rails/jbuilder.git
19+
```
20+
21+
#### Create a Topic Branch
22+
23+
Make sure your fork is up-to-date and create a topic branch for your feature or bug fix.
24+
25+
```
26+
git checkout master
27+
git pull upstream master
28+
git checkout -b my-feature-branch
29+
```
30+
31+
#### Bundle Install and Test
32+
33+
Ensure that you can build the project and run tests.
34+
35+
```
36+
bundle install
37+
bundle exec rake test
38+
```
39+
40+
#### Write Tests
41+
42+
Try to write a test that reproduces the problem you're trying to fix or describes a feature that you want to build. Add to [test](test).
43+
44+
We definitely appreciate pull requests that highlight or reproduce a problem, even without a fix.
45+
46+
#### Write Code
47+
48+
Implement your feature or bug fix.
49+
50+
Make sure that `bundle exec rake test` completes without errors.
51+
52+
#### Write Documentation
53+
54+
Document any external behavior in the [README](README.md).
55+
56+
#### Commit Changes
57+
58+
Make sure git knows your name and email address:
59+
60+
```
61+
git config --global user.name "Your Name"
62+
git config --global user.email "[email protected]"
63+
```
64+
65+
Writing good commit logs is important. A commit log should describe what changed and why.
66+
67+
```
68+
git add ...
69+
git commit
70+
```
71+
72+
#### Push
73+
74+
```
75+
git push origin my-feature-branch
76+
```
77+
78+
#### Make a Pull Request
79+
80+
Go to https://github.com/contributor/jbuilder and select your feature branch. Click the 'Pull Request' button and fill out the form. Pull requests are usually reviewed within a few days.
81+
82+
#### Rebase
83+
84+
If you've been working on a change for a while, rebase with upstream/master.
85+
86+
```
87+
git fetch upstream
88+
git rebase upstream/master
89+
git push origin my-feature-branch -f
90+
```
91+
92+
#### Check on Your Pull Request
93+
94+
Go back to your pull request after a few minutes and see whether it passed muster with Travis-CI. Everything should look green, otherwise fix issues and amend your commit as described above.
95+
96+
#### Be Patient
97+
98+
It's likely that your change will not be merged and that the nitpicky maintainers will ask you to do more, or fix seemingly benign problems. Hang on there!
99+
100+
#### Thank You
101+
102+
Please do know that we really appreciate and value your time and work. We love you, really.

MIT-LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
Copyright (c) 2011-2014 David Heinemeier Hansson, 37signals
1+
Copyright (c) 2011-2015 David Heinemeier Hansson, 37signals
22

33
Permission is hereby granted, free of charge, to any person obtaining
44
a copy of this software and associated documentation files (the

README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,5 @@
11
# Jbuilder
22

3-
[![Build Status](https://api.travis-ci.org/rails/jbuilder.svg)][travis]
4-
[![Gem Version](http://img.shields.io/gem/v/jbuilder.svg)][gem]
5-
[![Code Climate](http://img.shields.io/codeclimate/github/rails/jbuilder.svg)][codeclimate]
6-
[![Dependencies Status](http://img.shields.io/gemnasium/rails/jbuilder.svg)][gemnasium]
7-
8-
[travis]: https://travis-ci.org/rails/jbuilder
9-
[gem]: https://rubygems.org/gems/jbuilder
10-
[codeclimate]: https://codeclimate.com/github/rails/jbuilder
11-
[gemnasium]: https://gemnasium.com/rails/jbuilder
12-
133
Jbuilder gives you a simple DSL for declaring JSON structures that beats
144
massaging giant hash structures. This is particularly helpful when the
155
generation process is fraught with conditionals and loops. Here's a simple
@@ -258,3 +248,13 @@ for MultiJson:
258248
require 'multi_json'
259249
MultiJson.use :yajl
260250
```
251+
252+
## Contributing to Jbuilder
253+
254+
Jbuilder is work of many contributors. You're encouraged to submit pull requests, propose
255+
features and discuss issues.
256+
257+
See [CONTRIBUTING](CONTRIBUTING.md).
258+
259+
## License
260+
Jbuilder is released under the [MIT License](http://www.opensource.org/licenses/MIT).

0 commit comments

Comments
 (0)