Skip to content

Commit 1324561

Browse files
authored
Merge pull request #146 from swanson/swanson/failing-nil-test
Kredis.hash fails with nil values in Redis 5+
2 parents 4fbb2f5 + eb68a92 commit 1324561

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

lib/kredis/types/hash.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def []=(key, value)
1818
end
1919

2020
def update(**entries)
21-
hset entries.transform_values { |val| type_to_string(val, typed) } if entries.flatten.any?
21+
hset entries.transform_values { |val| type_to_string(val, typed) }.compact if entries.flatten.any?
2222
end
2323

2424
def values_at(*keys)

test/types/hash_test.rb

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,4 +124,10 @@ class HashTest < ActiveSupport::TestCase
124124
@hash = Kredis.hash "myhash", typed: :integer, default: ->() { { space_invaders: "100", pong: "42" } }
125125
assert_equal({ "space_invaders" => 100, "pong" => 42 }, @hash.to_h)
126126
end
127+
128+
test "handles nil values gracefully" do
129+
@hash.update("key" => nil, "key2" => "value2")
130+
assert_nil @hash["key"]
131+
assert_equal "value2", @hash["key2"]
132+
end
127133
end

0 commit comments

Comments
 (0)