Skip to content

Commit 6a5b461

Browse files
authored
Merge pull request #54 from julianrubisch/missing-hash-callbacks
Add []= and remove to hash callback methods
2 parents 1f82f98 + 1ffcc4c commit 6a5b461

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

lib/kredis/types/callbacks_proxy.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class Kredis::Types::CallbacksProxy
77
Kredis::Types::Cycle => %i[ next ],
88
Kredis::Types::Enum => %i[ value= reset ],
99
Kredis::Types::Flag => %i[ mark remove ],
10-
Kredis::Types::Hash => %i[ update delete ],
10+
Kredis::Types::Hash => %i[ update delete []= remove ],
1111
Kredis::Types::List => %i[ remove prepend append << ],
1212
Kredis::Types::Scalar => %i[ value= clear ],
1313
Kredis::Types::Set => %i[ add << remove replace take clear ],

test/attributes_callbacks_test.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,12 @@ def id
5757
assert_callback_executed_for :kredis_hash, :proc, ->(type) { type.update space_invaders: 100, pong: 42 }
5858
assert_callback_executed_for :kredis_hash, :method, ->(type) { type.update space_invaders: 100, pong: 42 }
5959

60+
assert_callback_executed_for :kredis_hash, :proc, ->(type) { type[:space_invaders] = 0 }
61+
assert_callback_executed_for :kredis_hash, :method, ->(type) { type[:space_invaders] = 0 }
62+
6063
assert_callback_executed_for :kredis_hash, :proc, ->(type) { type.delete "key" }
64+
65+
assert_callback_executed_for :kredis_hash, :method, ->(type) { type.remove }
6166
end
6267

6368
private

0 commit comments

Comments
 (0)