Skip to content

Commit a1287a9

Browse files
authored
Eliminating Ruby Warnings (#112)
* ⚠️ `*' interpreted as argument prefix * ⚠️ ambiguous first argument; put parentheses or a space even after `-' operator
1 parent 2f17bad commit a1287a9

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

lib/kredis/migration.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,10 @@ def migrate(from:, to:, pipeline: nil)
3333
def delete_all(*key_patterns)
3434
log_migration "DELETE ALL #{key_patterns.inspect}" do
3535
if key_patterns.length > 1
36-
@redis.del *key_patterns
36+
@redis.del(*key_patterns)
3737
else
3838
each_key_batch_matching(key_patterns.first) do |keys, pipeline|
39-
pipeline.del *keys
39+
pipeline.del(*keys)
4040
end
4141
end
4242
end

lib/kredis/types/proxying.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ class Kredis::Types::Proxying
44
attr_accessor :proxy, :key
55

66
def self.proxying(*commands)
7-
delegate *commands, to: :proxy
7+
delegate(*commands, to: :proxy)
88
end
99

1010
def initialize(redis, key, **options)

lib/kredis/types/unique_list.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def append(elements)
2222
multi do
2323
remove elements
2424
super
25-
ltrim -limit, -1 if limit
25+
ltrim(-limit, -1) if limit
2626
end
2727
end
2828
alias << append

test/migration_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class MigrationTest < ActiveSupport::TestCase
6262
test "delete_all with keys" do
6363
3.times { |index| Kredis.proxy("mykey:#{index}").set "hello there #{index}" }
6464

65-
Kredis::Migration.delete_all *3.times.map { |index| "mykey:#{index}" }
65+
Kredis::Migration.delete_all(*3.times.map { |index| "mykey:#{index}" })
6666

6767
3.times { |index| assert_nil Kredis.proxy("mykey:#{index}").get }
6868
end

0 commit comments

Comments
 (0)