Fix datetime shift in job filter for non-UTC timezones (#278)

* use datetime-local format in tests for job filters

* test job filters in different time zone

* fix date and time parsing in job filters

* format

Author: otariidae

app/controllers/concerns/mission_control/jobs/job_filters.rb

@@ -36,6 +36,6 @@ def finished_at_range_params
     end
 
     def parse_with_time_zone(date)
-      DateTime.parse(date).in_time_zone if date.present?
+      Time.zone.parse(date) if date.present?
     end
 end

test/controllers/jobs_controller_test.rb

@@ -43,24 +43,28 @@ class MissionControl::Jobs::JobsControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "get finished jobs filtered by finished_at date" do
-    job = DummyJob.perform_later(42)
-    perform_enqueued_jobs_async
-
-    get mission_control_jobs.application_jobs_url(@application, :finished)
-    assert_response :ok
-    assert_select "tr.job", 1
-
-    get mission_control_jobs.application_jobs_url(@application, :finished, filter: { finished_at_start: 1.hour.from_now.to_s })
-    assert_response :ok
-    assert_select "tr.job", 0
-
-    get mission_control_jobs.application_jobs_url(@application, :finished, filter: { finished_at_start: 1.hour.ago.to_s, finished_at_end: 1.hour.from_now })
-    assert_response :ok
-    assert_select "tr.job", 1
-
-    get mission_control_jobs.application_jobs_url(@application, :finished, filter: { finished_at_end: 1.hour.from_now })
-    assert_response :ok
-    assert_select "tr.job", 1
+    [ "UTC", "International Date Line West" ].each do |timezone|
+      Time.use_zone(timezone) do
+        job = DummyJob.perform_later(42)
+        perform_enqueued_jobs_async
+
+        get mission_control_jobs.application_jobs_url(@application, :finished)
+        assert_response :ok
+        assert_select "tr.job", 1
+
+        get mission_control_jobs.application_jobs_url(@application, :finished, filter: { finished_at_start: 1.hour.from_now.strftime("%Y-%m-%dT%H:%M") })
+        assert_response :ok
+        assert_select "tr.job", 0
+
+        get mission_control_jobs.application_jobs_url(@application, :finished, filter: { finished_at_start: 1.hour.ago.strftime("%Y-%m-%dT%H:%M"), finished_at_end: 1.hour.from_now.strftime("%Y-%m-%dT%H:%M") })
+        assert_response :ok
+        assert_select "tr.job", 1
+
+        get mission_control_jobs.application_jobs_url(@application, :finished, filter: { finished_at_end: 1.hour.from_now.strftime("%Y-%m-%dT%H:%M") })
+        assert_response :ok
+        assert_select "tr.job", 1
+      end
+    end
   end
 
   test "redirect to queue when job doesn't exist" do