You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds note to README.md regarding CSS bundling issues on vendored libs
From version 0.5.0 to 0.6.0, `bulma.min.css` was vendored into the lib instead of linking to the CDN version to better conform to the content security policy.
Unfortunately, when passing through a common older CSS bundler (sass-rails) during `rails assets:precompile`, that CSS doesn't seem to pass muster:
```
SassC::SyntaxError: Error: Invalid CSS after "...--s),var(--l));": expected "}", was "--00-l:var(--bulma-" (SassC::SyntaxError)
```
I assume Bulma is using some feature of DartSass/CSS that `sass-rails` and `sassc-rails` do not support. Updating the CSS bundler to `dartsass-rails` fixes the issue.
Copy file name to clipboardExpand all lines: README.md
+2Lines changed: 2 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -45,6 +45,8 @@ $ bundle install
45
45
46
46
And you should be ready to go.
47
47
48
+
*Note: Legacy CSS bundlers `sass-rails` and `sassc-rails` may fail to compile some of the CSS vendored into this library from [Bulma](https://github.com/jgthms/bulma), which was created in [Dart SASS](https://sass-lang.com/dart-sass/). You will therefore need to upgrade to `dartsass-rails` or some library that relies on it, like `cssbundling-rails`.*
49
+
48
50
### Authentication and base controller class
49
51
50
52
By default, Mission Control's controllers will extend the host app's `ApplicationController`. If no authentication is enforced, `/jobs` will be available to everyone. You might want to implement some kind of authentication for this in your app. To make this easier, you can specify a different controller as the base class for Mission Control's controllers:
0 commit comments