Skip to content

Commit ac664d8

Browse files
junketrosa
authored andcommitted
Adds note to README.md regarding CSS bundling issues on vendored libs
From version 0.5.0 to 0.6.0, `bulma.min.css` was vendored into the lib instead of linking to the CDN version to better conform to the content security policy. Unfortunately, when passing through a common older CSS bundler (sass-rails) during `rails assets:precompile`, that CSS doesn't seem to pass muster: ``` SassC::SyntaxError: Error: Invalid CSS after "...--s),var(--l));": expected "}", was "--00-l:var(--bulma-" (SassC::SyntaxError) ``` I assume Bulma is using some feature of DartSass/CSS that `sass-rails` and `sassc-rails` do not support. Updating the CSS bundler to `dartsass-rails` fixes the issue.
1 parent 217f344 commit ac664d8

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ $ bundle install
4545

4646
And you should be ready to go.
4747

48+
*Note: Legacy CSS bundlers `sass-rails` and `sassc-rails` may fail to compile some of the CSS vendored into this library from [Bulma](https://github.com/jgthms/bulma), which was created in [Dart SASS](https://sass-lang.com/dart-sass/). You will therefore need to upgrade to `dartsass-rails` or some library that relies on it, like `cssbundling-rails`.*
49+
4850
### Authentication and base controller class
4951

5052
By default, Mission Control's controllers will extend the host app's `ApplicationController`. If no authentication is enforced, `/jobs` will be available to everyone. You might want to implement some kind of authentication for this in your app. To make this easier, you can specify a different controller as the base class for Mission Control's controllers:

0 commit comments

Comments
 (0)