Remove base_controller_class loading in development (#236)

* Remove base_controller_class loading

* Fix rubocop

* Forgot to add test/dummy/app/controllers/my_application_controller.r

* Rubocop again

Author: tight

lib/mission_control/jobs/engine.rb

@@ -63,13 +63,6 @@ class Engine < ::Rails::Engine
       end
 
       config.after_initialize do |app|
-        unless app.config.eager_load
-          # When loading classes lazily (development), we want to make sure
-          # the base host +ApplicationController+ class is loaded when loading the
-          # Engine's +ApplicationController+, or it will fail to load the class.
-          MissionControl::Jobs.base_controller_class.constantize
-        end
-
         if MissionControl::Jobs.applications.empty?
           queue_adapters_by_name = MissionControl::Jobs.adapters.each_with_object({}) do |adapter, hsh|
             hsh[adapter] = ActiveJob::QueueAdapters.lookup(adapter).new

test/dummy/app/controllers/my_application_controller.rb

@@ -0,0 +1,2 @@
+class MyApplicationController < ApplicationController
+end

test/dummy/config/environments/test.rb

@@ -52,6 +52,7 @@
   config.solid_queue.connects_to = { database: { writing: :queue } }
 
   config.mission_control.jobs.http_basic_auth_enabled = false
+  config.mission_control.jobs.base_controller_class = "MyApplicationController"
 
   # Silence Solid Queue logging
   config.solid_queue.logger = ActiveSupport::Logger.new(nil)

test/mission_control/jobs/base_application_controller_test.rb

@@ -4,4 +4,8 @@ class MissionControl::Jobs::BaseApplicationControllerTest < ActiveSupport::TestC
   test "engine's ApplicationController inherits from host's ApplicationController by default" do
     assert MissionControl::Jobs::ApplicationController < ApplicationController
   end
+
+  test "engine's ApplicationController inherits from configured base_controller_class" do
+    assert MissionControl::Jobs::ApplicationController < MyApplicationController
+  end
 end