Skip to content

finished_at_start/end job filters #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Dec 2, 2024
Merged

finished_at_start/end job filters #111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
704cb86
jobs_relation finished_at_start and finished_at_end filters
Xeitor Apr 5, 2024
5ca0682
natively_supported finished_at_* filters for solid_queue
Xeitor Apr 5, 2024
b469206
added filters to _filters partial and params
Xeitor Apr 6, 2024
2e4291d
added timezone
Xeitor Apr 6, 2024
5b41d16
show finished_at filters if jobs_status is 'finished'
Xeitor Apr 7, 2024
60eec4d
added comments to jobs_relation where method
Xeitor Apr 10, 2024
b2c0808
clean finished_at_* filter values when clear button clicked
Xeitor Apr 10, 2024
f0753a9
double instead of single quoted strings (rubocop)
Xeitor Apr 10, 2024
62d5b3b
enhacements set filters
Xeitor Jun 10, 2024
ef2e964
Merge branch 'main' into jobs_finished_at_filters
Xeitor Nov 12, 2024
a8073e7
finished_at range enhacement
Xeitor Nov 17, 2024
3525169
enhace date_with_time_zone method
Xeitor Nov 17, 2024
5503402
back to @job_filters in _filters
Xeitor Nov 17, 2024
38b3bf3
god bye presence
Xeitor Nov 17, 2024
25142b7
bye collect arguments with to_s for values
Xeitor Nov 17, 2024
9d95d16
fix tests
Xeitor Nov 17, 2024
4d7cb3e
bringed back .to_s for queue_name parameters (JobsRelation#where)
Xeitor Nov 24, 2024
02547a2
queue_name back to symbol
Xeitor Nov 25, 2024
2d17d1e
bye finished_at from FILTERS
Xeitor Nov 25, 2024
4295a3d
bye comment
Xeitor Nov 25, 2024
0b07af3
added finished_at in supported_job_filters (SolidQueue)
Xeitor Nov 25, 2024
a82d2d8
Update app/views/mission_control/jobs/jobs/_filters.html.erb
Xeitor Nov 26, 2024
7b10cf4
Update lib/active_job/jobs_relation.rb
Xeitor Nov 26, 2024
ae91239
finished_at_range_params method
Xeitor Nov 27, 2024
e0bcd98
double quotes
Xeitor Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/active_job/jobs_relation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ def initialize(queue_adapter: ActiveJob::Base.queue_adapter, default_page_size:
def where(job_class_name: nil, queue_name: nil, worker_id: nil, recurring_task_id: nil, finished_at: nil)
# Remove nil arguments to avoid overriding parameters when concatenating +where+ clauses
arguments = { job_class_name: job_class_name,
queue_name: queue_name,
queue_name: queue_name&.to_s,
worker_id: worker_id,
recurring_task_id: recurring_task_id,
finished_at: finished_at
Expand Down
2 changes: 1 addition & 1 deletion test/active_job/queue_adapters/adapter_testing/discard_jobs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::DiscardJobs
5.times { FailingJob.perform_later }
10.times { FailingReloadedJob.perform_later }
perform_enqueued_jobs
ActiveJob.jobs.failed.where(queue_name: 'queue_1').discard_all
ActiveJob.jobs.failed.where(queue_name: :queue_1).discard_all

assert_empty ActiveJob.jobs.failed.where(job_class_name: "FailingJob")
assert_equal 10, ActiveJob.jobs.failed.where(job_class_name: "FailingReloadedJob").count
Expand Down
2 changes: 1 addition & 1 deletion test/active_job/queue_adapters/adapter_testing/retry_jobs.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ module ActiveJob::QueueAdapters::AdapterTesting::RetryJobs

assert_equal 15, ActiveJob.jobs.failed.count

failed_jobs = ActiveJob.jobs.failed.where(queue_name: 'queue_2')
failed_jobs = ActiveJob.jobs.failed.where(queue_name: :queue_2)
failed_jobs.retry_all

assert_equal 10, ActiveJob.jobs.failed.count
Expand Down