From 0a2ce06ca27801cd72a5f8172f8aefbde19a7b2e Mon Sep 17 00:00:00 2001
From: Felipe <felipe.barbosa@iugu.com>
Date: Wed, 20 Nov 2024 00:35:40 -0300
Subject: [PATCH 1/2] Remake pagination component

---
 .../jobs/shared/_pagination_toolbar.html.erb  | 37 +++++++++++++++++--
 1 file changed, 33 insertions(+), 4 deletions(-)

diff --git a/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb b/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb
index d71a025a..6e99fc6a 100644
--- a/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb
+++ b/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb
@@ -1,5 +1,34 @@
-<nav class="buttons is-right" role="navigation" aria-label="pagination">
-  <span class="mr-3"><%= page.index %> / <%= page.pages_count || "..." %></span>
-  <%= link_to "Previous page", url_for(page: page.previous_index, **filter_param), class: "pagination-previous", disabled: page.first? %>
-  <%= link_to "Next page", url_for(page: page.next_index, **filter_param), class: "pagination-next", disabled: page.last? %>
+<nav class="pagination is-centered is-small" role="navigation" aria-label="pagination">
+  <ul class="pagination-list">
+    <% unless page.first? %>
+      <li>
+        <%= link_to "1", url_for(page: 1, **filter_param), class: 'pagination-link', disabled: page.first? %>
+      </li>
+      <% unless (page.index - 1) == 1 %>
+        <li><span class="pagination-ellipsis">&hellip;</span></li>
+        <li>
+          <%= link_to page.previous_index, url_for(page: page.previous_index, **filter_param), class: 'pagination-link', disabled: page.first? %>
+        </li>
+      <% end
+    end %>
+    <li>
+      <a
+        class="pagination-link is-current"
+        aria-label="Page 46"
+        aria-current="page"
+        ><%= page.index %></a
+      >
+    </li>
+    <% unless page.last? %>
+    <li>
+      <%= link_to page.next_index, url_for(page: page.next_index, **filter_param), class: 'pagination-link', disabled: page.last? %>
+    </li>
+      <% unless (page.index + 1) == page.pages_count %>
+        <li><span class="pagination-ellipsis">&hellip;</span></li>
+        <li>
+          <%= link_to page.pages_count, url_for(page: page.pages_count, **filter_param), class: 'pagination-link', disabled: page.last? %>
+        </li>
+      <% end
+    end %>
+  </ul>
 </nav>

From 2158fc365bbf73ffd0a74e663dec7d97c85d97ae Mon Sep 17 00:00:00 2001
From: Felipe <felipe.barbosa@iugu.com>
Date: Wed, 4 Dec 2024 19:26:41 -0300
Subject: [PATCH 2/2] fix/Tests

---
 .../jobs/shared/_pagination_toolbar.html.erb  |  2 +-
 test/controllers/workers_controller_test.rb   | 30 +++++++++++++++++--
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb b/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb
index 6e99fc6a..ca50b384 100644
--- a/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb
+++ b/app/views/mission_control/jobs/shared/_pagination_toolbar.html.erb
@@ -14,7 +14,7 @@
     <li>
       <a
         class="pagination-link is-current"
-        aria-label="Page 46"
+        aria-label="Page <%= page.index %>"
         aria-current="page"
         ><%= page.index %></a
       >
diff --git a/test/controllers/workers_controller_test.rb b/test/controllers/workers_controller_test.rb
index 7003aaac..20e9e863 100644
--- a/test/controllers/workers_controller_test.rb
+++ b/test/controllers/workers_controller_test.rb
@@ -23,8 +23,34 @@ class MissionControl::Jobs::WorkersControllerTest < ActionDispatch::IntegrationT
       get mission_control_jobs.application_workers_url(@application)
       assert_response :ok
 
-      assert_select "tr.worker", 2
-      assert_select "nav[aria-label=\"pagination\"]", /1 \/ 3/
+      assert_select "nav.pagination[role=\"navigation\"][aria-label=\"pagination\"]" do
+        assert_select "ul.pagination-list" do
+          assert_select "li a.pagination-link", text: "1", count: 1
+          assert_select "li a.pagination-link", text: "2", count: 1
+          assert_select "li a.pagination-link", text: "3", count: 1
+        end
+
+        assert_select "li span.pagination-ellipsis", text: "…", count: 1
+      end
+    end
+  end
+
+  test "paginate workers with multiple pages" do
+    register_workers(count: 20)
+
+    stub_const(MissionControl::Jobs::Page, :DEFAULT_PAGE_SIZE, 2) do
+      get mission_control_jobs.application_workers_url(@application)
+      assert_response :ok
+
+      assert_select "nav.pagination[role=\"navigation\"][aria-label=\"pagination\"]" do
+        assert_select "ul.pagination-list" do
+          assert_select "li a.pagination-link", text: "1", count: 1
+          assert_select "li a.pagination-link", text: "2", count: 1
+          assert_select "li a.pagination-link", text: "10", count: 1
+        end
+
+        assert_select "li span.pagination-ellipsis", text: "…", count: 1
+      end
     end
   end