Skip to content

Add basic theme select #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+35 −0
Open

Add basic theme select #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/javascript/mission_control/jobs/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@
import "@hotwired/turbo-rails"
import "controllers"
import "helpers"
import "helpers/theme_select";
14 changes: 14 additions & 0 deletions app/javascript/mission_control/jobs/helpers/theme_select.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
document.addEventListener("turbo:load", function() {
const select = document.getElementById("theme-select");
if (!select) return;

const theme = document.documentElement.getAttribute("data-theme") || "system";
select.value = theme;
select.style.visibility = "visible";

select.addEventListener("change", function() {
const theme = this.value;
document.documentElement.setAttribute("data-theme", theme);
localStorage.setItem("mission_control_theme", theme);
});
});
11 changes: 11 additions & 0 deletions app/views/layouts/mission_control/jobs/_theming.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<div class="field">
<div class="control">
<div class="select">
<select id="theme-select" style="visibility:hidden">
<option value="system">System</option>
<option value="light">Light</option>
<option value="dark">Dark</option>
</select>
</div>
</div>
</div>
9 changes: 9 additions & 0 deletions app/views/layouts/mission_control/jobs/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
<!DOCTYPE html>
<html>
<head>
<script>
(function() {
var theme = localStorage.getItem("mission_control_theme") || "system";
document.documentElement.setAttribute("data-theme", theme);
})();
Copy link
Member

@rosa rosa Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should follow the gem's conventions, so that no JavaScript code is included directly like this.

</script>
<title>Mission control - <%= page_title %></title>
<%= csrf_meta_tags %>
<%= csp_meta_tag %>
Expand All @@ -16,6 +22,9 @@

<section class="section">
<div class="container">
<div class="navbar-end">
<%= render "layouts/mission_control/jobs/theming" %>
</div>
<%= render "layouts/mission_control/jobs/application_selection" %>
<%= render "layouts/mission_control/jobs/flash" %>
<%= render "layouts/mission_control/jobs/navigation" %>
Expand Down