From 5d4f4313076565c492a56d5ab254dffc960e0717 Mon Sep 17 00:00:00 2001 From: Harsh Deep Date: Thu, 16 Oct 2025 12:36:26 -0400 Subject: [PATCH 1/2] add mapping fix for Harsh and Harsh Deep --- app/models/names_manager/canonical_names.rb | 1 + test/credits/canonical_names_test.rb | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/app/models/names_manager/canonical_names.rb b/app/models/names_manager/canonical_names.rb index b46e3c4a..6229000b 100644 --- a/app/models/names_manager/canonical_names.rb +++ b/app/models/names_manager/canonical_names.rb @@ -1193,6 +1193,7 @@ def self.map(canonical_name, *also_as) map 'Zhang Kang', 'piecehealth', 'Kang Zhang' map 'Zheng Jia', 'zhengjia' map 'zzak', 'Zachary Scott' + map 'Harsh Deep', 'Harsh', "harsh.deep\100moderntreasury.com" # Reverse SEEN_ALSO_AS to be able to go from handler to canonical name. CANONICAL_NAME_FOR = {} SEEN_ALSO_AS.each do |canonical_name, also_as| diff --git a/test/credits/canonical_names_test.rb b/test/credits/canonical_names_test.rb index 2cb170cc..0eb3f88a 100644 --- a/test/credits/canonical_names_test.rb +++ b/test/credits/canonical_names_test.rb @@ -5159,5 +5159,9 @@ class CanonicalNamesTest < ActiveSupport::TestCase test 'प्रथमेश Sonpatki' do assert_contributor_names 'a7a2bc0f66', 'Prathamesh Sonpatki' end + + test 'Harsh' do + assert_contributor_names '5ff38f4', 'Harsh Deep' + end end end From 308f3239de194f851afa630b0f2e6a147729828e Mon Sep 17 00:00:00 2001 From: Harsh Deep Date: Thu, 16 Oct 2025 14:17:09 -0400 Subject: [PATCH 2/2] Fix DHH duplicate contributor entries Map lowercase 'dhh' to 'David Heinemeier Hansson' to consolidate the 5 commits authored as 'dhh' with the main contributor profile. This fixes the issue where DHH appeared twice on contributors.rubyonrails.org: - https://contributors.rubyonrails.org/contributors/dhh/commits (5 commits) - https://contributors.rubyonrails.org/contributors/david-heinemeier-hansson/commits (4910 commits) The mapping already included 'DHH' (uppercase) but was missing 'dhh' (lowercase). --- app/models/names_manager/canonical_names.rb | 2 +- test/credits/canonical_names_test.rb | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/app/models/names_manager/canonical_names.rb b/app/models/names_manager/canonical_names.rb index 6229000b..17becf66 100644 --- a/app/models/names_manager/canonical_names.rb +++ b/app/models/names_manager/canonical_names.rb @@ -359,7 +359,7 @@ def self.map(canonical_name, *also_as) map 'David Easley', "easleydp\100gmail.com" map 'David Felstead', "david.felstead\100gmail.com", "dfelstead\100site5.com" map 'David François', 'David FRANCOIS', 'davout' - map 'David Heinemeier Hansson', 'DHH', 'David' # for David see 5d5f0bad6e934d9d4fad7d0fa4643d04c13709a9 + map 'David Heinemeier Hansson', 'DHH', 'dhh', 'David' # for David see 5d5f0bad6e934d9d4fad7d0fa4643d04c13709a9 map 'David Morton', "mortonda\100dgrmm.net" map 'David N. Welton', 'davidw' map 'David Raynes', 'rayners' diff --git a/test/credits/canonical_names_test.rb b/test/credits/canonical_names_test.rb index 0eb3f88a..74d9ac81 100644 --- a/test/credits/canonical_names_test.rb +++ b/test/credits/canonical_names_test.rb @@ -5163,5 +5163,9 @@ class CanonicalNamesTest < ActiveSupport::TestCase test 'Harsh' do assert_contributor_names '5ff38f4', 'Harsh Deep' end + + test 'dhh' do + assert_contributor_names 'dd6f3e1', 'David Heinemeier Hansson' + end end end