fix tests

Author: Francesco Rodriguez

test/fixtures/alternate_config_project/config/environments/production.rb

@@ -4,6 +4,8 @@
   # Code is not reloaded between requests
   config.cache_classes = true
 
+  config.eager_load = true
+
   # Full error reports are disabled and caching is turned on
   config.consider_all_requests_local       = false
   config.action_controller.perform_caching = true

test/fixtures/alternate_config_project/config/environments/test.rb

@@ -35,7 +35,4 @@
 
   # Print deprecation notices to the stderr
   config.active_support.deprecation = :stderr
-
-  # Set to compact only for testing purposes.
-  config.sass.style = :compact
 end

test/sass_rails_test.rb

@@ -1,54 +1,46 @@
 require 'test_helper'
 
 class SassRailsTest < Sass::Rails::TestCase
-  test "classes are loaded" do
+  test 'classes are loaded' do
     assert_kind_of Module, Sass::Rails
-    assert_kind_of Class, Sass::Rails::CssCompressor
     assert_kind_of Class, Sass::Rails::Railtie
   end
 
-  test 'style config item is honored' do
+  test 'style config item is honored in development mode' do
     within_rails_app 'alternate_config_project' do
-      runcmd "ruby script/rails runner 'puts Rails.application.config.sass.style'", Dir.pwd, true, "Gemfile", {"RAILS_ENV" => "development"}
+      runcmd "ruby script/rails runner 'puts Rails.application.config.sass.style'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'development'}
       assert_output /compact/
     end
   end
 
+  test 'style config item is not honored if environment is not development' do
+    within_rails_app 'alternate_config_project' do
+      runcmd "ruby script/rails runner 'p Rails.application.config.sass.style'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'production'}
+      assert_equal 'nil', $last_ouput.chomp
+    end
+  end
+
   test 'css_compressor config item is not honored in development mode' do
     within_rails_app 'alternate_config_project' do
-      runcmd "ruby script/rails runner 'p Rails.application.config.assets.css_compressor'", Dir.pwd, true, "Gemfile", {"RAILS_ENV" => "development"}
+      runcmd "ruby script/rails runner 'p Rails.application.config.assets.css_compressor'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'development'}
       assert_equal 'nil', $last_ouput.chomp
     end
   end
 
   test 'css_compressor config item is honored if environment is not development' do
     within_rails_app 'alternate_config_project' do
-      runcmd "ruby script/rails runner 'puts Rails.application.config.assets.css_compressor'", Dir.pwd, true, "Gemfile", {"RAILS_ENV" => "production"}
+      runcmd "ruby script/rails runner 'puts Rails.application.config.assets.css_compressor'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'production'}
       assert_output /yui/
     end
   end
 
   test 'sass uses expanded style by default in development mode' do
     within_rails_app 'scss_project' do
-      runcmd "ruby script/rails runner 'puts Rails.application.config.sass.style'", Dir.pwd, true, "Gemfile", {'RAILS_ENV' => 'development'}
+      runcmd "ruby script/rails runner 'puts Rails.application.config.sass.style'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'development'}
       assert_output /expanded/
     end
   end
 
-  test 'sass uses compressed style by default in test mode' do
-    within_rails_app 'scss_project' do
-      runcmd "ruby script/rails runner 'puts Rails.application.config.sass.style'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'test'}
-      assert_output /compressed/
-    end
-  end
-
-  test 'sass uses compressed style by default in production mode' do
-    within_rails_app 'scss_project' do
-      runcmd "ruby script/rails runner 'puts Rails.application.config.sass.style'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'production'}
-      assert_output /compressed/
-    end
-  end
-
   test 'sass not defines compressor in development mode' do
     within_rails_app 'scss_project' do
       runcmd "ruby script/rails runner 'p Rails.application.config.assets.css_compressor'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'development'}
@@ -59,42 +51,24 @@ class SassRailsTest < Sass::Rails::TestCase
   test 'sass defines compressor by default in test mode' do
     within_rails_app 'scss_project' do
       runcmd "ruby script/rails runner 'puts Rails.application.config.assets.css_compressor'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'test'}
-      assert_output /Sass::Rails::CssCompressor/
+      assert_equal 'sass', $last_ouput.chomp
     end
   end
 
   test 'sass defines compressor by default in production mode' do
     within_rails_app 'scss_project' do
       runcmd "ruby script/rails runner 'puts Rails.application.config.assets.css_compressor'", Dir.pwd, true, 'Gemfile', {'RAILS_ENV' => 'production'}
-      assert_output /Sass::Rails::CssCompressor/
+      assert_equal 'sass', $last_ouput.chomp
     end
   end
 
-  # This tests both the railtie responsible for passing in the :compact style, and the compressor for honoring it
-  test "compressor outputs compact style when specified in config" do
-    command =<<END_OF_COMMAND
-puts Rails.application.config.assets.css_compressor.compress(<<CSS)
-div {
-  color: red;
-}
-span {
-  color: blue;
-}
-CSS
-END_OF_COMMAND
-    within_rails_app "alternate_config_project" do
-      runcmd "ruby script/rails runner '#{command}'", Dir.pwd, true, "Gemfile", {"RAILS_ENV" => "test"}
-      assert_line_count 3
-    end
-  end
-
-  test "sprockets require works correctly" do
-    css_output = sprockets_render("scss_project", "css_application.css")
+  test 'sprockets require works correctly' do
+    css_output = sprockets_render('scss_project', 'css_application.css')
     assert_match /globbed/, css_output
   end
 
-  test "sass imports work correctly" do
-    css_output = sprockets_render("scss_project", "application.css.scss")
+  test 'sass imports work correctly' do
+    css_output = sprockets_render('scss_project', 'application.css.scss')
     assert_match /main/,                     css_output
     assert_match /top-level/,                css_output
     assert_match /partial-sass/,             css_output
@@ -109,8 +83,8 @@ class SassRailsTest < Sass::Rails::TestCase
     assert_match /without-css-ext/,          css_output
   end
 
-  test "sass asset paths work" do
-    css_output = sprockets_render("scss_project", "application.css.scss")
+  test 'sass asset paths work' do
+    css_output = sprockets_render('scss_project', 'application.css.scss')
     assert_match %r{asset-path:\s*"/assets/rails.png"},                           css_output, 'asset-path:\s*"/assets/rails.png"'
     assert_match %r{asset-url:\s*url\(/assets/rails.png\)},                       css_output, 'asset-url:\s*url\(/assets/rails.png\)'
     assert_match %r{image-path:\s*"/assets/rails.png"},                           css_output, 'image-path:\s*"/assets/rails.png"'
@@ -130,15 +104,7 @@ class SassRailsTest < Sass::Rails::TestCase
     asset_data_url_regexp = %r{asset-data-url:\s*url\((.*?)\)}
     assert_match asset_data_url_regexp, css_output, 'asset-data-url:\s*url\((.*?)\)'
     asset_data_url_match = css_output.match(asset_data_url_regexp)[1]
-    asset_data_url_expected = "data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyRpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw%2FeHBhY2tldCBiZWdpbj0i77u%2FIiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8%2BIDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYxIDY0LjE0MDk0OSwgMjAxMC8xMi8wNy0xMDo1NzowMSAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNS4xIE1hY2ludG9zaCIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDpCNzY5NDE1QkQ2NkMxMUUwOUUzM0E5Q0E2RTgyQUExQiIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDpCNzY5NDE1Q0Q2NkMxMUUwOUUzM0E5Q0E2RTgyQUExQiI%2BIDx4bXBNTTpEZXJpdmVkRnJvbSBzdFJlZjppbnN0YW5jZUlEPSJ4bXAuaWlkOkE3MzcyNTQ2RDY2QjExRTA5RTMzQTlDQTZFODJBQTFCIiBzdFJlZjpkb2N1bWVudElEPSJ4bXAuZGlkOkI3Njk0MTVBRDY2QzExRTA5RTMzQTlDQTZFODJBQTFCIi8%2BIDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY%2BIDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8%2B0HhJ9AAAABBJREFUeNpi%2BP%2F%2FPwNAgAEACPwC%2FtuiTRYAAAAASUVORK5CYII%3D"
+    asset_data_url_expected = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyRpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw%2FeHBhY2tldCBiZWdpbj0i77u%2FIiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8%2BIDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuMC1jMDYxIDY0LjE0MDk0OSwgMjAxMC8xMi8wNy0xMDo1NzowMSAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENTNS4xIE1hY2ludG9zaCIgeG1wTU06SW5zdGFuY2VJRD0ieG1wLmlpZDpCNzY5NDE1QkQ2NkMxMUUwOUUzM0E5Q0E2RTgyQUExQiIgeG1wTU06RG9jdW1lbnRJRD0ieG1wLmRpZDpCNzY5NDE1Q0Q2NkMxMUUwOUUzM0E5Q0E2RTgyQUExQiI%2BIDx4bXBNTTpEZXJpdmVkRnJvbSBzdFJlZjppbnN0YW5jZUlEPSJ4bXAuaWlkOkE3MzcyNTQ2RDY2QjExRTA5RTMzQTlDQTZFODJBQTFCIiBzdFJlZjpkb2N1bWVudElEPSJ4bXAuZGlkOkI3Njk0MTVBRDY2QzExRTA5RTMzQTlDQTZFODJBQTFCIi8%2BIDwvcmRmOkRlc2NyaXB0aW9uPiA8L3JkZjpSREY%2BIDwveDp4bXBtZXRhPiA8P3hwYWNrZXQgZW5kPSJyIj8%2B0HhJ9AAAABBJREFUeNpi%2BP%2F%2FPwNAgAEACPwC%2FtuiTRYAAAAASUVORK5CYII%3D'
     assert_equal asset_data_url_expected, asset_data_url_match
   end
-
-  test "css compressor compresses" do
-    assert_equal "div{color:red}\n", Sass::Rails::CssCompressor.new.compress(<<CSS)
-div {
-  color: red;
-}
-CSS
-  end
 end