Guard usage of new process_name to link claimed executions

We can only use this if new migrations have been run. If not, we just
emit a deprecation warning and continue as before.

Author: rosa

app/models/solid_queue/claimed_execution.rb

@@ -1,7 +1,18 @@
 # frozen_string_literal: true
 
 class SolidQueue::ClaimedExecution < SolidQueue::Execution
-  belongs_to :process, primary_key: :name, foreign_key: :process_name
+  def self.process_name_column_exists?
+    column_names.include?("process_name")
+  end
+
+  if process_name_column_exists?
+    belongs_to :process, primary_key: :name, foreign_key: :process_name
+  else
+    warn_about_pending_migrations
+
+    belongs_to :process
+    attr_accessor :process_name
+  end
 
   scope :orphaned, -> { where.missing(:process) }
 
@@ -13,7 +24,10 @@ def success?
 
   class << self
     def claiming(job_ids, process, &block)
-      process_data = { process_id: process.id, process_name: process.name }
+      process_data = { process_id: process.id }.tap do |hsh|
+        hsh[:process_name] = process.name if process_name_column_exists?
+      end
+
       job_data = Array(job_ids).collect { |job_id| { job_id: job_id }.merge(process_data) }
 
       SolidQueue.instrument(:claim, job_ids: job_ids, **process_data) do |payload|
@@ -45,8 +59,8 @@ def fail_all_with(error)
             execution.unblock_next_job
           end
 
-          payload[:process_ids] = executions.map(&:process_id).uniq
-          payload[:process_names] = executions.map(&:process_name).uniq
+          payload[:process_ids] = executions.map(&:process_id).uniq.presence
+          payload[:process_names] = executions.map(&:process_name).uniq.presence
           payload[:job_ids] = executions.map(&:job_id).uniq
           payload[:size] = executions.size
         end

app/models/solid_queue/process/executor.rb

@@ -6,7 +6,13 @@ module Executor
       extend ActiveSupport::Concern
 
       included do
-        has_many :claimed_executions, primary_key: :name, foreign_key: :process_name
+        if ClaimedExecution.process_name_column_exists?
+          has_many :claimed_executions, primary_key: :name, foreign_key: :process_name
+        else
+          warn_about_pending_migrations
+
+          has_many :claimed_executions
+        end
 
         after_destroy :release_all_claimed_executions
       end

app/models/solid_queue/record.rb

@@ -6,11 +6,23 @@ class Record < ActiveRecord::Base
 
     connects_to(**SolidQueue.connects_to) if SolidQueue.connects_to
 
-    def self.non_blocking_lock
-      if SolidQueue.use_skip_locked
-        lock(Arel.sql("FOR UPDATE SKIP LOCKED"))
-      else
-        lock
+    class << self
+      def non_blocking_lock
+        if SolidQueue.use_skip_locked
+          lock(Arel.sql("FOR UPDATE SKIP LOCKED"))
+        else
+          lock
+        end
+      end
+
+      def warn_about_pending_migrations
+        SolidQueue.deprecator.warn(<<~DEPRECATION)
+          Solid Queue has pending database migrations. To get the new migration files, run:
+            rails solid_queue:update
+          And then:
+            rails db:migrate
+          These migrations will be required after version 2.0
+        DEPRECATION
       end
     end
   end

test/integration/processes_lifecycle_test.rb

@@ -271,7 +271,7 @@ class ProcessesLifecycleTest < ActiveSupport::TestCase
 
   private
     def assert_clean_termination
-      wait_for_registered_processes 0, timeout: 0.2.second
+      wait_for_registered_processes 0, timeout: 0.5.second
       assert_no_registered_processes
       assert_no_claimed_jobs
       assert_not process_exists?(@pid)