Skip to content

Commit 4152fab

Browse files
committed
Add size of claimed executions related to deregister_process event
1 parent e855a33 commit 4152fab

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

app/models/solid_queue/process.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ def heartbeat
2525
end
2626

2727
def deregister(pruned: false)
28-
SolidQueue.instrument :deregister_process, process: self, pruned: pruned do
28+
SolidQueue.instrument :deregister_process, process: self, pruned: pruned, claimed_size: claimed_executions.size do
2929
destroy!
3030
end
3131
rescue Exception => error

test/integration/instrumentation_test.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class InstrumentationTest < ActiveSupport::TestCase
3838
end
3939

4040
test "starting and stopping a worker emits register_process and deregister_process events" do
41+
StoreResultJob.perform_later(42, pause: SolidQueue.shutdown_timeout + 10.second)
4142
process = nil
4243

4344
events = subscribed(/(register|deregister)_process\.solid_queue/) do
@@ -52,9 +53,8 @@ class InstrumentationTest < ActiveSupport::TestCase
5253

5354
assert_equal 2, events.size
5455
register_event, deregister_event = events
55-
5656
assert_event register_event, "register_process", kind: "Worker", pid: ::Process.pid
57-
assert_event deregister_event, "deregister_process", process: process, pruned: false
57+
assert_event deregister_event, "deregister_process", process: process, pruned: false, claimed_size: 1
5858
end
5959

6060
test "pruning processes emit prune_processes and deregister_process events" do
@@ -75,7 +75,7 @@ class InstrumentationTest < ActiveSupport::TestCase
7575

7676
assert_event prune_event, "prune_processes", size: 3
7777
deregister_events.each_with_index do |event, i|
78-
assert_event event, "deregister_process", process: processes[i], pruned: true
78+
assert_event event, "deregister_process", process: processes[i], pruned: true, claimed_size: 0
7979
end
8080
end
8181

0 commit comments

Comments
 (0)