Skip to content

Commit 42b4b71

Browse files
tannakartikeyrosa
authored andcommitted
Modified enqueue_after_transaction_commit to be true by default
1 parent c4ecefb commit 42b4b71

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ There are several settings that control how Solid Queue works that you can set a
171171
- `preserve_finished_jobs`: whether to keep finished jobs in the `solid_queue_jobs` table—defaults to `true`.
172172
- `clear_finished_jobs_after`: period to keep finished jobs around, in case `preserve_finished_jobs` is true—defaults to 1 day. **Note:** Right now, there's no automatic cleanup of finished jobs. You'd need to do this by periodically invoking `SolidQueue::Job.clear_finished_in_batches`, but this will happen automatically in the near future.
173173
- `default_concurrency_control_period`: the value to be used as the default for the `duration` parameter in [concurrency controls](#concurrency-controls). It defaults to 3 minutes.
174-
- `enqueue_after_transaction_commit`: it defines whether the job should be enqueued after `after_commit`. [Read more](https://github.com/rails/rails/pull/51426) about it.
174+
- `enqueue_after_transaction_commit`: it defines whether the job should be enqueued after `after_commit`. The default is `true`. [Read more](https://github.com/rails/rails/pull/51426) about it.
175175

176176

177177
## Concurrency controls

lib/solid_queue.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ module SolidQueue
2828

2929
mattr_accessor :shutdown_timeout, default: 5.seconds
3030

31-
mattr_accessor :enqueue_after_transaction_commit, default: false
31+
mattr_accessor :enqueue_after_transaction_commit, default: true
3232

3333
mattr_accessor :silence_polling, default: true
3434

0 commit comments

Comments
 (0)