Don't delete persisted recurring tasks when the dispatcher shuts down

Author: rosa

lib/solid_queue/dispatcher/recurring_schedule.rb

@@ -33,8 +33,6 @@ def schedule_task(task)
     def unschedule_tasks
       scheduled_tasks.values.each(&:cancel)
       scheduled_tasks.clear
-
-      wrap_in_app_executor { delete_tasks }
     end
 
     def task_keys
@@ -50,10 +48,6 @@ def reload_tasks
         @configured_tasks = SolidQueue::RecurringTask.where(key: task_keys)
       end
 
-      def delete_tasks
-        SolidQueue::RecurringTask.static.delete_all
-      end
-
       def schedule(task)
         scheduled_task = Concurrent::ScheduledTask.new(task.delay_from_now, args: [ self, task, task.next_time ]) do |thread_schedule, thread_task, thread_task_run_at|
           thread_schedule.schedule_task(thread_task)

test/integration/recurring_tasks_test.rb

@@ -48,9 +48,9 @@ class RecurringTasksTest < ActiveSupport::TestCase
 
     assert_recurring_tasks configured_task
     terminate_process(@pid)
-    assert_recurring_tasks []
 
-    SolidQueue::RecurringTask.create!(key: "periodic_store_result", class_name: "StoreResultJob", schedule: "every minute", arguments: [ 42 ])
+    task = SolidQueue::RecurringTask.find_by(key: "periodic_store_result")
+    task.update!(class_name: "StoreResultJob", schedule: "every minute", arguments: [ 42 ])
 
     @pid = run_supervisor_as_fork
     wait_for_registered_processes(4, timeout: 3.second)
@@ -75,8 +75,6 @@ class RecurringTasksTest < ActiveSupport::TestCase
     terminate_process(@pid)
     dispatcher1.stop
     dispatcher2.stop
-
-    assert_recurring_tasks []
   end
 
   private