Add LoggingTestHelper and refactor tests to use it

Introduced LoggingTestHelper to encapsulate logging-related test
utilities. Updated ActiveSupport::TestCase to include the new helper and
removed redundant logging methods from DispatcherTest and WorkerTest,
improving code organization and maintainability.

Author: faraquet

.github/workflows/main.yml

@@ -29,10 +29,12 @@ jobs:
         - 3.3
         - 3.4
         database: [ mysql, postgres, sqlite ]
-        gemfile: [ rails_7_1, rails_7_2, rails_8_0, rails_main ]
+        gemfile: [ rails_7_1, rails_7_2, rails_8_0, rails_8_1, rails_main ]
         exclude:
           - ruby-version: "3.1"
             gemfile: rails_8_0
+          - ruby-version: "3.1"
+            gemfile: rails_8_1
           - ruby-version: "3.1"
             gemfile: rails_main
     services:

Appraisals

@@ -15,6 +15,10 @@ appraise "rails-8-0" do
   gem "railties", "~> 8.0.0"
 end
 
+appraise "rails-8-1" do
+  gem "railties", "~> 8.1.0"
+end
+
 appraise "rails-main" do
   gem "railties", github: "rails/rails", branch: "main"
 end

Rakefile

@@ -5,7 +5,9 @@ require "bundler/setup"
 APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
 load "rails/tasks/engine.rake"
 
-load "rails/tasks/statistics.rake"
+if Rails::VERSION::MAJOR < 8
+  load "rails/tasks/statistics.rake"
+end
 
 require "bundler/gem_tasks"
 require "rake/tasklib"

gemfiles/rails_8_1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "railties", "~> 8.1.0"
+
+gemspec path: "../"

test/test_helper.rb

@@ -28,7 +28,7 @@ class ExpectedTestError < RuntimeError; end
 
 
 class ActiveSupport::TestCase
-  include ConfigurationTestHelper, ProcessesTestHelper, JobsTestHelper
+  include ConfigurationTestHelper, ProcessesTestHelper, JobsTestHelper, LoggingTestHelper
 
   setup do
     @_on_thread_error = SolidQueue.on_thread_error

test/test_helpers/logging_test_helper.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module LoggingTestHelper
+  private
+    def rails_uses_structured_event_logging?
+      defined?(ActiveSupport::EventReporter) &&
+        defined?(ActiveRecord::LogSubscriber) &&
+        defined?(ActiveSupport::EventReporter::LogSubscriber) &&
+        ActiveRecord::LogSubscriber < ActiveSupport::EventReporter::LogSubscriber
+    end
+
+    def with_polling(silence:)
+      old_silence_polling, SolidQueue.silence_polling = SolidQueue.silence_polling, silence
+      yield
+    ensure
+      SolidQueue.silence_polling = old_silence_polling
+    end
+
+    def with_active_record_logger(logger)
+      old_ar_logger, ActiveRecord::Base.logger = ActiveRecord::Base.logger, logger
+      structured = rails_uses_structured_event_logging?
+
+      if structured
+        old_as_ls_logger, ActiveSupport::LogSubscriber.logger = ActiveSupport::LogSubscriber.logger, logger
+        old_debug_mode = ActiveSupport.event_reporter.debug_mode?
+        ActiveSupport.event_reporter.debug_mode = true
+      end
+      yield
+    ensure
+      ActiveRecord::Base.logger = old_ar_logger
+
+      if structured
+        ActiveSupport::LogSubscriber.logger = old_as_ls_logger
+        ActiveSupport.event_reporter.debug_mode = old_debug_mode
+      end
+    end
+end

test/unit/dispatcher_test.rb

@@ -118,19 +118,4 @@ class DispatcherTest < ActiveSupport::TestCase
     dispatcher.start
     wait_while_with_timeout(1.second) { !SolidQueue::ScheduledExecution.exists? }
   end
-
-  private
-    def with_polling(silence:)
-      old_silence_polling, SolidQueue.silence_polling = SolidQueue.silence_polling, silence
-      yield
-    ensure
-      SolidQueue.silence_polling = old_silence_polling
-    end
-
-    def with_active_record_logger(logger)
-      old_logger, ActiveRecord::Base.logger = ActiveRecord::Base.logger, logger
-      yield
-    ensure
-      ActiveRecord::Base.logger = old_logger
-    end
 end

test/unit/worker_test.rb

@@ -192,19 +192,4 @@ class WorkerTest < ActiveSupport::TestCase
     @worker.start
     sleep 1.second
   end
-
-  private
-    def with_polling(silence:)
-      old_silence_polling, SolidQueue.silence_polling = SolidQueue.silence_polling, silence
-      yield
-    ensure
-      SolidQueue.silence_polling = old_silence_polling
-    end
-
-    def with_active_record_logger(logger)
-      old_logger, ActiveRecord::Base.logger = ActiveRecord::Base.logger, logger
-      yield
-    ensure
-      ActiveRecord::Base.logger = old_logger
-    end
 end