Generalize inserting a batch of executions from a batch of jobs

From now, used only when moving scheduled executions to ready executions.

Also, change `assume_attributes_from_job` to `assumes_attributes_from_job`,
3rd person singular, to be consistent with other similar methods.

Author: rosa

app/models/solid_queue/blocked_execution.rb

@@ -2,7 +2,7 @@
 
 module SolidQueue
   class BlockedExecution < Execution
-    assume_attributes_from_job :concurrency_key
+    assumes_attributes_from_job :concurrency_key
     before_create :set_expires_at
 
     has_one :semaphore, foreign_key: :key, primary_key: :concurrency_key

app/models/solid_queue/execution.rb

@@ -11,5 +11,17 @@ class Execution < Record
     belongs_to :job
 
     alias_method :discard, :destroy
+
+    class << self
+      def create_all_from_jobs(jobs)
+        insert_all execution_data_from_jobs(jobs)
+      end
+
+      def execution_data_from_jobs(jobs)
+        jobs.collect do |job|
+          attributes_from_job(job).merge(job_id: job.id)
+        end
+      end
+    end
   end
 end

app/models/solid_queue/execution/job_attributes.rb

@@ -5,17 +5,24 @@ class Execution
     module JobAttributes
       extend ActiveSupport::Concern
 
-      ASSUMIBLE_ATTRIBUTES_FROM_JOB = %i[ queue_name priority ]
+      included do
+        class_attribute :assumible_attributes_from_job, instance_accessor: false, default: %i[ queue_name priority ]
+      end
 
       class_methods do
-        def assume_attributes_from_job(*attributes)
-          before_create -> { assume_attributes_from_job(ASSUMIBLE_ATTRIBUTES_FROM_JOB | attributes) }
+        def assumes_attributes_from_job(*attribute_names)
+          self.assumible_attributes_from_job |= attribute_names
+          before_create -> { assume_attributes_from_job }
+        end
+
+        def attributes_from_job(job)
+          job.attributes.symbolize_keys.slice(*assumible_attributes_from_job)
         end
       end
 
       private
-        def assume_attributes_from_job(attributes)
-          attributes.each do |attribute|
+        def assume_attributes_from_job
+          self.class.assumible_attributes_from_job.each do |attribute|
             send("#{attribute}=", job.send(attribute))
           end
         end

app/models/solid_queue/ready_execution.rb

@@ -4,7 +4,7 @@ module SolidQueue
   class ReadyExecution < Execution
     scope :queued_as, ->(queue_name) { where(queue_name: queue_name) }
 
-    assume_attributes_from_job
+    assumes_attributes_from_job
 
     class << self
       def claim(queue_list, limit, process_id)

app/models/solid_queue/scheduled_execution.rb

@@ -6,7 +6,7 @@ class ScheduledExecution < Execution
     scope :ordered, -> { order(scheduled_at: :asc, priority: :asc) }
     scope :next_batch, ->(batch_size) { due.ordered.limit(batch_size) }
 
-    assume_attributes_from_job :scheduled_at
+    assumes_attributes_from_job :scheduled_at
 
     class << self
       def dispatch_next_batch(batch_size)
@@ -34,19 +34,13 @@ def dispatch_batch(job_ids)
         end
 
         def dispatch_at_once(jobs)
-          ReadyExecution.insert_all ready_rows_from_batch(jobs)
+          ReadyExecution.create_all_from_jobs jobs
         end
 
         def dispatch_one_by_one(jobs)
           jobs.each(&:dispatch)
         end
 
-        def ready_rows_from_batch(jobs)
-          jobs.map do |job|
-            { job_id: job.id, queue_name: job.queue_name, priority: job.priority }
-          end
-        end
-
         def successfully_dispatched(job_ids)
           dispatched_and_ready(job_ids) + dispatched_and_blocked(job_ids)
         end

test/models/solid_queue/job_test.rb

@@ -65,7 +65,7 @@ class NonOverlappingGroupedJob2 < NonOverlappingJob
     assert_equal solid_queue_job, execution.job
     assert_equal "test", execution.queue_name
     assert_equal 8, execution.priority
-    assert Time.now < execution.scheduled_at
+    assert_equal solid_queue_job.scheduled_at, execution.scheduled_at
   end
 
   test "enqueue jobs without concurrency controls" do