Fix and simplify logging of recurring tasks enqueuing

Set level to debug for successful enqueue + skipping, and error for
errors, instead of info for everything.

Author: rosa

lib/solid_queue/log_subscriber.rb

@@ -47,16 +47,12 @@ def enqueue_recurring_task(event)
     attributes = event.payload.slice(:task, :active_job_id, :enqueue_error)
     attributes[:at] = event.payload[:at]&.iso8601
 
-    if event.payload[:other_adapter]
-      action = attributes[:active_job_id].present? ? "Enqueued recurring task outside Solid Queue" : "Error enqueuing recurring task"
-      debug formatted_event(event, action: action, **attributes)
+    if attributes[:active_job_id].nil? && event.payload[:skipped].nil?
+      error formatted_event(event, action: "Error enqueuing recurring task", **attributes)
+    elsif event.payload[:other_adapter]
+      debug formatted_event(event, action: "Enqueued recurring task outside Solid Queue", **attributes)
     else
-      action = case
-      when event.payload[:skipped].present? then "Skipped recurring task – already dispatched"
-      when attributes[:active_job_id].nil?  then "Error enqueuing recurring task"
-      else                                       "Enqueued recurring task"
-      end
-
+      action = event.payload[:skipped].present? ? "Skipped recurring task – already dispatched" : "Enqueued recurring task"
       debug formatted_event(event, action: action, **attributes)
     end
   end

test/unit/log_subscriber_test.rb

@@ -31,23 +31,23 @@ def set_logger(logger)
     time = Time.now
     instrument "enqueue_recurring_task.solid_queue", task: :example_task, active_job_id: "b944ddbc-6a37-43c0-b661-4b56e57195f5", at: time
 
-    assert_match_logged :info, "Enqueued recurring task", "task: :example_task, active_job_id: \"b944ddbc-6a37-43c0-b661-4b56e57195f5\", at: \"#{time.iso8601}\""
+    assert_match_logged :debug, "Enqueued recurring task", "task: :example_task, active_job_id: \"b944ddbc-6a37-43c0-b661-4b56e57195f5\", at: \"#{time.iso8601}\""
   end
 
   test "recurring task skipped" do
     attach_log_subscriber
     time = Time.now
     instrument "enqueue_recurring_task.solid_queue", task: :example_task, skipped: true, at: time
 
-    assert_match_logged :info, "Skipped recurring task – already dispatched", "task: :example_task, at: \"#{time.iso8601}\""
+    assert_match_logged :debug, "Skipped recurring task – already dispatched", "task: :example_task, at: \"#{time.iso8601}\""
   end
 
   test "error enqueuing recurring task" do
     attach_log_subscriber
     time = Time.now
     instrument "enqueue_recurring_task.solid_queue", task: :example_task, enqueue_error: "Everything is broken", at: time
 
-    assert_match_logged :info, "Error enqueuing recurring task", "task: :example_task, enqueue_error: \"Everything is broken\", at: \"#{time.iso8601}\""
+    assert_match_logged :error, "Error enqueuing recurring task", "task: :example_task, enqueue_error: \"Everything is broken\", at: \"#{time.iso8601}\""
   end
 
   test "deregister process" do