Implement preserved jobs test and remove todo

Author: jpcamara

test/integration/batch_lifecycle_test.rb

@@ -31,6 +31,7 @@ def assert_finished_in_order(*batches)
     SolidQueue::BatchRecord.destroy_all
 
     ApplicationJob.enqueue_after_transaction_commit = false if defined?(ApplicationJob.enqueue_after_transaction_commit)
+    SolidQueue.preserve_finished_jobs = true
   end
 
   class BatchOnSuccessJob < ApplicationJob
@@ -231,13 +232,24 @@ def perform
     assert_finished_in_order(batch2, batch1)
   end
 
-  # TODO: spec for each callback type firing properly
-
   test "preserve_finished_jobs = false" do
-    # SolidQueue.preserve_finished_jobs = false
-    # batch1 = SolidQueue::Batch.enqueue do
-    #   AddToBufferJob.perform_later "hey"
-    # end
+    SolidQueue.preserve_finished_jobs = false
+    batch1 = SolidQueue::Batch.enqueue do
+      AddToBufferJob.perform_later "hey"
+    end
+
+    assert_equal false, batch1.reload.finished?
+    assert_equal 1, SolidQueue::Job.count
+    assert_equal 0, SolidQueue::Job.finished.count
+
+    @dispatcher.start
+    @worker.start
+
+    wait_for_job_batches_to_finish_for(2.seconds)
+    wait_for_jobs_to_finish_for(2.seconds)
+
+    assert_equal true, batch1.reload.finished?
+    assert_equal 0, SolidQueue::Job.count
   end
 
   test "batch interface" do