Refactor and simplify process callbacks setup

Author: rosa

lib/solid_queue.rb

@@ -10,6 +10,7 @@
 require "solid_queue/processes/supervised"
 require "solid_queue/processes/registrable"
 require "solid_queue/processes/interruptible"
+require "solid_queue/processes/callbacks"
 require "solid_queue/processes/pidfile"
 require "solid_queue/processes/procline"
 require "solid_queue/processes/poller"

lib/solid_queue/dispatcher.rb

@@ -6,8 +6,8 @@ class Dispatcher < Processes::Base
 
     attr_accessor :batch_size, :concurrency_clerk
 
-    set_callback :boot, :after, :launch_concurrency_maintenance, if: :concurrency_clerk?
-    set_callback :shutdown, :before, :stop_concurrency_maintenance, if: :concurrency_clerk?
+    after_boot :launch_concurrency_maintenance, if: :concurrency_clerk?
+    before_shutdown :stop_concurrency_maintenance, if: :concurrency_clerk?
 
     def initialize(**options)
       options = options.dup.with_defaults(SolidQueue::Configuration::DISPATCHER_DEFAULTS)

lib/solid_queue/processes/base.rb

@@ -3,22 +3,14 @@
 module SolidQueue
   module Processes
     class Base
-      include ActiveSupport::Callbacks
-      define_callbacks :boot, :shutdown
-
+      include Callbacks # Defines callbacks needed by other concerns
       include AppExecutor, Registrable, Interruptible, Procline
 
       private
         def observe_initial_delay
           interruptible_sleep(initial_jitter)
         end
 
-        def boot
-        end
-
-        def shutdown
-        end
-
         def initial_jitter
           0
         end

lib/solid_queue/processes/callbacks.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+module SolidQueue::Processes
+  module Callbacks
+    extend ActiveSupport::Concern
+
+    included do
+      extend ActiveModel::Callbacks
+      define_model_callbacks :boot, :shutdown
+    end
+
+    private
+      def boot
+      end
+
+      def shutdown
+      end
+  end
+end

lib/solid_queue/processes/registrable.rb

@@ -5,11 +5,10 @@ module Registrable
     extend ActiveSupport::Concern
 
     included do
-      set_callback :boot, :after, :register
-      set_callback :boot, :after, :launch_heartbeat
+      after_boot :register, :launch_heartbeat
 
-      set_callback :shutdown, :before, :stop_heartbeat
-      set_callback :shutdown, :after, :deregister
+      before_shutdown :stop_heartbeat
+      after_shutdown :deregister
     end
 
     def inspect

lib/solid_queue/supervisor.rb

@@ -4,7 +4,7 @@ module SolidQueue
   class Supervisor < Processes::Base
     include Processes::Signals
 
-    set_callback :boot, :after, :launch_process_prune
+    after_boot :launch_process_prune
 
     class << self
       def start(mode: :work, load_configuration_from: nil)