Attempt to reduce flakiness of scheduler_test
#686
+16
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-schlickmann
force-pushed
the
scheduler-flake
branch
from
c94bcaf to
9652313
Compare
p-schlickmann
commented
Nov 18, 2025
|
|
||
| test "starting and stopping a worker emits register_process and deregister_process events" do | ||
| StoreResultJob.perform_later(42, pause: SolidQueue.shutdown_timeout + 100.second) | ||
| StoreResultJob.perform_later(42, pause: SolidQueue.shutdown_timeout + 15.seconds) |
Contributor
Author
There was a problem hiding this comment.
Not related to scheduler_test, but I don't think this is ever a good idea, to have a timeout that long 😅
|
|
||
| unless self.class.use_transactional_tests | ||
| destroy_records | ||
| end |
Contributor
Author
There was a problem hiding this comment.
In theory, destroy_records will always run in teardown, even if a test fails.
But I also added it in setup to be extra sure records aren't leaking between tests, if for some reason teardown can't run because of a deadlock or a :KILL signal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #602
Attempting to fix the latest flake against main