Skip to content

Commit 0e231fb

Browse files
committed
Remove support to old rubies
1 parent 0579aa4 commit 0e231fb

File tree

4 files changed

+4
-44
lines changed

4 files changed

+4
-44
lines changed

.travis.yml

Lines changed: 1 addition & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,6 @@ language: ruby
22
cache: bundler
33
sudo: false
44
rvm:
5-
- 1.9.3 # when removed, get rid of the before_script hack and also the one in application_generator.rb
6-
- 2.0.0
7-
- 2.1.10
8-
- 2.2.10
9-
- 2.3.8
105
- 2.4.6
116
- 2.5.5
127
- 2.6.3
@@ -17,25 +12,7 @@ env:
1712
- RAILS_VERSION="~> 5.1.0"
1813
- RAILS_VERSION="~> 5.2.0"
1914
matrix:
20-
exclude: # Rails 5 is incompatible with Ruby < 2.2.2
21-
- rvm: 1.9.3
22-
env: RAILS_VERSION="~> 5.0.0"
23-
- rvm: 2.0.0
24-
env: RAILS_VERSION="~> 5.0.0"
25-
- rvm: 2.1.10
26-
env: RAILS_VERSION="~> 5.0.0"
27-
- rvm: 1.9.3
28-
env: RAILS_VERSION="~> 5.1.0"
29-
- rvm: 2.0.0
30-
env: RAILS_VERSION="~> 5.1.0"
31-
- rvm: 2.1.10
32-
env: RAILS_VERSION="~> 5.1.0"
33-
- rvm: 1.9.3
34-
env: RAILS_VERSION="~> 5.2.0"
35-
- rvm: 2.0.0
36-
env: RAILS_VERSION="~> 5.2.0"
37-
- rvm: 2.1.10
38-
env: RAILS_VERSION="~> 5.2.0"
15+
exclude:
3916
- rvm: 2.6.3
4017
env: RAILS_VERSION="~> 4.2.0"
4118
allow_failures:
@@ -45,6 +22,4 @@ before_install:
4522
- gem update --system 3.0.3
4623
- gem uninstall bundler && gem install bundler -v 1.17.3
4724
before_script:
48-
- "[ $TRAVIS_RUBY_VERSION = \"1.9.3\" ] && travis_retry gem install mime-types --version \"~> 2\" || true"
49-
- "[ $TRAVIS_RUBY_VERSION = \"1.9.3\" -o $TRAVIS_RUBY_VERSION = \"2.0.0\" ] && travis_retry gem install nokogiri --version \"~> 1.6.8\" || true"
5025
- travis_retry gem install rails --version "$RAILS_VERSION"

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## Next release
22

3+
* Drop support to Ruby 1.9, 2.0, 2.1, and 2.3
34
* Fix binstubs not being replaced when their quoting style was changed (#534)
45
* Preserve comments right after the shebang line which might include magic comments such as `frozen_string_literal: true'
56
* Fix binstub failures when Bundler's `BUNDLE_APP_CONFIG` environment variable is present (#545)

lib/spring/test/application_generator.rb

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,6 @@ def generate
3838

3939
# Sporadic SSL errors keep causing test failures so there are anti-SSL workarounds here
4040
def generate_files
41-
if RUBY_VERSION == "1.9.3"
42-
system("gem list '^mime-types$' --installed --version '~> 2' || " \
43-
"gem install mime-types --clear-sources --source http://rubygems.org --version '~> 2'")
44-
end
45-
4641
system("gem list '^rails$' --installed --version '#{version_constraint}' || " \
4742
"gem install rails --clear-sources --source http://rubygems.org --version '#{version_constraint}'")
4843

@@ -94,21 +89,8 @@ def generate_if_missing
9489
def install_spring
9590
return if @installed
9691

97-
if RUBY_VERSION < "2.2.2"
98-
application.run! "gem install activesupport --version '#{version}'"
99-
end
100-
10192
build_and_install_gems
10293

103-
# TO prevent nokogiri install error in application.bundle.
104-
if RUBY_VERSION < "2.1.0"
105-
append_to_file(application.gemfile, "gem 'nokogiri', '~> 1.6.8'")
106-
end
107-
108-
if RUBY_VERSION < "1.9"
109-
append_to_file(application.gemfile, "gem 'rake', '12.2.1'")
110-
end
111-
11294
application.bundle
11395

11496
FileUtils.rm_rf application.path("bin")

spring.gemspec

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ Gem::Specification.new do |gem|
1313
gem.files = Dir["LICENSE.txt", "README.md", "lib/**/*", "bin/*"]
1414
gem.executables = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
1515

16+
gem.required_ruby_version = ">= 2.4.0"
17+
1618
gem.add_development_dependency 'rake'
1719
gem.add_development_dependency 'bump'
1820
gem.add_development_dependency 'activesupport'

0 commit comments

Comments
 (0)